public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ralf Wildenhues <Ralf.Wildenhues@gmx.de>
To: Tobias Burnus <burnus@net-b.de>
Cc: gcc patches <gcc-patches@gcc.gnu.org>
Subject: Re: [Build, Patch, libquadmath] PR 46520   Do not call AC_CHECK_LIB for gcc_no_link
Date: Sun, 19 Dec 2010 13:00:00 -0000	[thread overview]
Message-ID: <20101219120803.GK7020@gmx.de> (raw)
In-Reply-To: <4D0C8A2C.3080209@net-b.de>

Hi Tobias,

* Tobias Burnus wrote on Sat, Dec 18, 2010 at 11:17:16AM CET:
> The title says all. I am not sure whether this patch is sufficient
> but it is the next step to fix the build. (The symbol-versioning
> check might still fail on bare irons.)
> 
> OK for the trunk?

Is the usage of the two HAVE_* defines for optimization only?
Then the patch is OK.  But you might still consider adding a case
statement in the gcc_no_link branch seeding the correct defines
or the respective configure cache variables (ac_cv_lib_m_cbrtl etc)
for targets where the functions are known to be available.

For configure choices that are not just used for optimization,
of course that becomes required procedure.

Thanks,
Ralf

> 2010-12-18  Tobias Burnus  <burnus@net-b.de>
> 
> 	PR fortran/46520
> 	* configure.ac: Do not call AC_CHECK_LIB for gcc_no_link.
> 	* configure: Regenerate
> 
> diff --git a/libquadmath/configure.ac b/libquadmath/configure.ac
> index 56b1fcb..603d2c1 100644
> --- a/libquadmath/configure.ac
> +++ b/libquadmath/configure.ac
> @@ -109,8 +109,10 @@ esac
>  AC_SUBST(toolexecdir)
>  AC_SUBST(toolexeclibdir)
>  
> -AC_CHECK_LIB([m],[sqrtl],[AC_DEFINE([HAVE_SQRTL],[1],[libm includes sqrtl])])
> -AC_CHECK_LIB([m],[cbrtl],[AC_DEFINE([HAVE_CBRTL],[1],[libm includes cbrtl])])
> +if test x$gcc_no_link != xyes; then
> +  AC_CHECK_LIB([m],[sqrtl],[AC_DEFINE([HAVE_SQRTL],[1],[libm includes sqrtl])])
> +  AC_CHECK_LIB([m],[cbrtl],[AC_DEFINE([HAVE_CBRTL],[1],[libm includes cbrtl])])
> +fi
>  
>  # Check for symbol versioning (copied from libssp).
>  AC_MSG_CHECKING([whether symbol versioning is supported])

  reply	other threads:[~2010-12-19 12:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-18 11:57 Tobias Burnus
2010-12-19 13:00 ` Ralf Wildenhues [this message]
2010-12-19 17:30   ` Tobias Burnus
2010-12-19 19:17     ` Ralf Wildenhues
2010-12-19 19:37       ` Tobias Burnus
2010-12-19 20:32         ` Ralf Wildenhues
2010-12-20 10:19         ` Joseph S. Myers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20101219120803.GK7020@gmx.de \
    --to=ralf.wildenhues@gmx.de \
    --cc=burnus@net-b.de \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).