From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19667 invoked by alias); 19 Dec 2010 12:08:13 -0000 Received: (qmail 19650 invoked by uid 22791); 19 Dec 2010 12:08:10 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mailout-de.gmx.net (HELO mail.gmx.net) (213.165.64.22) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Sun, 19 Dec 2010 12:08:05 +0000 Received: (qmail invoked by alias); 19 Dec 2010 12:08:03 -0000 Received: from xdsl-89-0-87-89.netcologne.de (EHLO localhost.localdomain) [89.0.87.89] by mail.gmx.net (mp010) with SMTP; 19 Dec 2010 13:08:03 +0100 Received: from ralf by localhost.localdomain with local (Exim 4.69) (envelope-from ) id 1PUI3X-0002KP-Mz; Sun, 19 Dec 2010 13:08:03 +0100 Date: Sun, 19 Dec 2010 13:00:00 -0000 From: Ralf Wildenhues To: Tobias Burnus Cc: gcc patches Subject: Re: [Build, Patch, libquadmath] PR 46520 Do not call AC_CHECK_LIB for gcc_no_link Message-ID: <20101219120803.GK7020@gmx.de> Mail-Followup-To: Ralf Wildenhues , Tobias Burnus , gcc patches References: <4D0C8A2C.3080209@net-b.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D0C8A2C.3080209@net-b.de> User-Agent: Mutt/1.5.20 (2010-08-04) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-12/txt/msg01507.txt.bz2 Hi Tobias, * Tobias Burnus wrote on Sat, Dec 18, 2010 at 11:17:16AM CET: > The title says all. I am not sure whether this patch is sufficient > but it is the next step to fix the build. (The symbol-versioning > check might still fail on bare irons.) > > OK for the trunk? Is the usage of the two HAVE_* defines for optimization only? Then the patch is OK. But you might still consider adding a case statement in the gcc_no_link branch seeding the correct defines or the respective configure cache variables (ac_cv_lib_m_cbrtl etc) for targets where the functions are known to be available. For configure choices that are not just used for optimization, of course that becomes required procedure. Thanks, Ralf > 2010-12-18 Tobias Burnus > > PR fortran/46520 > * configure.ac: Do not call AC_CHECK_LIB for gcc_no_link. > * configure: Regenerate > > diff --git a/libquadmath/configure.ac b/libquadmath/configure.ac > index 56b1fcb..603d2c1 100644 > --- a/libquadmath/configure.ac > +++ b/libquadmath/configure.ac > @@ -109,8 +109,10 @@ esac > AC_SUBST(toolexecdir) > AC_SUBST(toolexeclibdir) > > -AC_CHECK_LIB([m],[sqrtl],[AC_DEFINE([HAVE_SQRTL],[1],[libm includes sqrtl])]) > -AC_CHECK_LIB([m],[cbrtl],[AC_DEFINE([HAVE_CBRTL],[1],[libm includes cbrtl])]) > +if test x$gcc_no_link != xyes; then > + AC_CHECK_LIB([m],[sqrtl],[AC_DEFINE([HAVE_SQRTL],[1],[libm includes sqrtl])]) > + AC_CHECK_LIB([m],[cbrtl],[AC_DEFINE([HAVE_CBRTL],[1],[libm includes cbrtl])]) > +fi > > # Check for symbol versioning (copied from libssp). > AC_MSG_CHECKING([whether symbol versioning is supported])