From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10173 invoked by alias); 4 Jan 2011 12:25:05 -0000 Received: (qmail 10164 invoked by uid 22791); 4 Jan 2011 12:25:03 -0000 X-SWARE-Spam-Status: No, hits=-1.3 required=5.0 tests=AWL,BAYES_00,MSGID_FROM_MTA_HEADER,SPF_SOFTFAIL,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mtagate2.uk.ibm.com (HELO mtagate2.uk.ibm.com) (194.196.100.162) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 04 Jan 2011 12:24:58 +0000 Received: from d06nrmr1307.portsmouth.uk.ibm.com (d06nrmr1307.portsmouth.uk.ibm.com [9.149.38.129]) by mtagate2.uk.ibm.com (8.13.1/8.13.1) with ESMTP id p04COsAl007664 for ; Tue, 4 Jan 2011 12:24:54 GMT Received: from d06av02.portsmouth.uk.ibm.com (d06av02.portsmouth.uk.ibm.com [9.149.37.228]) by d06nrmr1307.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id p04COuGN1585338 for ; Tue, 4 Jan 2011 12:24:56 GMT Received: from d06av02.portsmouth.uk.ibm.com (loopback [127.0.0.1]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id p04COsOe022965 for ; Tue, 4 Jan 2011 05:24:54 -0700 Received: from tuxmaker.boeblingen.de.ibm.com (tuxmaker.boeblingen.de.ibm.com [9.152.85.9]) by d06av02.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVin) with SMTP id p04COrfo022943; Tue, 4 Jan 2011 05:24:53 -0700 Message-Id: <201101041224.p04COrfo022943@d06av02.portsmouth.uk.ibm.com> Received: by tuxmaker.boeblingen.de.ibm.com (sSMTP sendmail emulation); Tue, 04 Jan 2011 13:24:52 +0100 Subject: Re: [patch] Do not crash on empty epilogues To: bernds@codesourcery.com (Bernd Schmidt) Date: Tue, 04 Jan 2011 12:39:00 -0000 From: "Ulrich Weigand" Cc: gcc-patches@gcc.gnu.org In-Reply-To: <4D227496.2010805@codesourcery.com> from "Bernd Schmidt" at Jan 04, 2011 02:15:02 AM MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-01/txt/msg00132.txt.bz2 Bernd Schmidt wrote: > On 01/04/2011 12:22 AM, Ulrich Weigand wrote: > > A couple of other targets that support naked functions work around this > > problem by generating some dummy insn (e.g. an UNSPEC_VOLATILE that > > expands to no assembler code). But this seems a bit silly to me; GCC > > common code simply shouldn't crash on empty epilogues. > > Ok. It would be nice to also avoid emitting the NOTE_INSN_EPILOGUE_BEG; > such a change is ok too if you want to make it. The same thing could > also be done for sibcall epilogues. > > Another way to fix it in the backend is to ensure HAVE_epilogue is false > if the epilogue would be empty. I've checked in the original patch now, as the minimal change to fix the regression. Any further changes can probably wait until we're back in stage 1 ... Thanks, Ulrich -- Dr. Ulrich Weigand GNU Toolchain for Linux on System z and Cell BE Ulrich.Weigand@de.ibm.com