From: "Ulrich Weigand" <uweigand@de.ibm.com>
To: joseph@codesourcery.com (Joseph S. Myers)
Cc: gcc-patches@gcc.gnu.org, trevor_smigiel@playstation.sony.com,
dje.gcc@gmail.com
Subject: [commit, spu] Remove ASM_SPEC (Re: [21/25] Specs cleanup: SPU)
Date: Thu, 27 Jan 2011 09:23:00 -0000 [thread overview]
Message-ID: <201101270841.p0R8feuX023190@d06av02.portsmouth.uk.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1101252240030.1203@digraph.polyomino.org.uk> from "Joseph S. Myers" at Jan 25, 2011 10:41:44 PM
Joseph Myers wrote:
> On Mon, 17 Jan 2011, Ulrich Weigand wrote:
>
> > Joseph Myers wrote:
> >
> > > * config/spu/spu-elf.h (ASM_SPEC): Remove %{w:-W}.
> >
> > I guess that's OK -- but I'm wondering why we then need to
> > keep any definition of ASM_SPEC here in the first place?
>
> In general when cleaning up specs I've left empty definitions rather than
> removing them, even if empty is the default, as something that is clearly
> safe as a local change - whereas removing the definition requires a
> further non-local check, that no config using this header was relying on
> overriding a definition of the same macro in a previous header listed in
> tm_file. If nothing is relying on the #undef-and-redefine-to-default - if
> it in fact has no effect on any target using the header - then it can be
> removed.
OK, I see. In our case, there is no other definition of ASM_SPEC, so
this can go away. I've checked in the patch below.
Tested on spu-elf.
Bye,
Ulrich
ChangeLog:
* config/spu/spu-elf.h (ASM_SPEC): Remove.
Index: gcc/config/spu/spu-elf.h
===================================================================
*** gcc/config/spu/spu-elf.h (revision 169143)
--- gcc/config/spu/spu-elf.h (working copy)
***************
*** 78,83 ****
mcache-size=8 :-lgcc_cache8k; \
:-lgcc_cache64k}"
- #undef ASM_SPEC
- #define ASM_SPEC ""
-
--- 78,80 ----
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com
next prev parent reply other threads:[~2011-01-27 8:41 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-14 0:03 [00/25] Specs cleanup: introduction Joseph S. Myers
2011-01-14 0:04 ` [01/25] Specs cleanup: -b (ARM) Joseph S. Myers
2011-01-14 10:09 ` Richard Earnshaw
2011-01-14 0:05 ` [02/25] Specs cleanup: assembler -v/-V (SPARC) Joseph S. Myers
2011-01-14 9:18 ` Eric Botcazou
2011-01-14 18:18 ` Joseph S. Myers
2011-01-14 0:06 ` [03/25] Specs cleanup: -version Joseph S. Myers
2011-01-14 10:13 ` Richard Earnshaw
2011-01-14 0:07 ` [05/25] Specs cleanup: -ibcs Joseph S. Myers
2011-01-14 10:37 ` Richard Guenther
2011-01-14 0:07 ` [04/25] Specs cleanup: -Yd, Joseph S. Myers
2011-01-14 9:47 ` Eric Botcazou
2011-01-26 18:18 ` Ping " Joseph S. Myers
2011-01-26 19:34 ` Richard Guenther
2011-01-14 0:08 ` [06/25] Specs cleanup: %{save-temps: } Joseph S. Myers
2011-01-14 7:58 ` Michael Eager
2011-01-14 12:02 ` Richard Guenther
2011-01-14 0:09 ` [07/25] Specs cleanup: -gline Joseph S. Myers
2011-01-14 8:37 ` Michael Eager
2011-01-14 0:10 ` [08/25] Specs cleanup: AVR Joseph S. Myers
2011-01-14 5:37 ` Weddington, Eric
2011-01-14 0:10 ` [09/25] Specs cleanup: CRIS Joseph S. Myers
2011-01-14 3:28 ` Hans-Peter Nilsson
2011-01-14 18:27 ` Joseph S. Myers
2011-01-14 19:41 ` Hans-Peter Nilsson
2011-01-14 21:31 ` Joseph S. Myers
2011-01-14 23:28 ` Hans-Peter Nilsson
2011-01-15 0:30 ` Joseph S. Myers
2011-01-15 1:14 ` Hans-Peter Nilsson
2011-01-15 9:08 ` Joseph S. Myers
2011-01-25 9:23 ` RFC: change the default for cross-targets to --with-sysroot=yes Hans-Peter Nilsson
2011-01-14 0:11 ` [10/25] Specs cleanup: NetWare Joseph S. Myers
2011-01-14 0:12 ` [12/25] Specs cleanup: microblaze Joseph S. Myers
2011-01-14 7:27 ` Michael Eager
2011-01-14 0:12 ` [11/25] Specs cleanup: config/m32r/little.h Joseph S. Myers
2011-01-14 12:07 ` Nick Clifton
2011-01-14 0:13 ` [13/25] Specs cleanup: MIPS -bestGnum -no_archive -exact_version Joseph S. Myers
2011-01-14 0:14 ` [14/25] Specs cleanup: MIPS -call_shared -non_shared Joseph S. Myers
2011-01-14 12:58 ` Richard Sandiford
2011-01-14 18:42 ` Joseph S. Myers
2011-01-15 14:24 ` Richard Sandiford
2011-01-14 0:15 ` [15/25] Specs cleanup: config/rs6000/sysv4.h SHARED_LIB_SUPPORT Joseph S. Myers
2011-01-17 16:38 ` David Edelsohn
2011-01-25 23:10 ` Joseph S. Myers
2011-01-14 0:16 ` [16/25] Specs cleanup: config/rs6000/sysv4.h LINK_PATH_SPEC Joseph S. Myers
2011-01-17 17:00 ` David Edelsohn
2011-01-14 0:17 ` [18/25] Specs cleanup: rs6000/vxworks.h -fvec* Joseph S. Myers
2011-01-14 9:03 ` Nathan Sidwell
2011-01-14 0:17 ` [17/25] Specs cleanup: rs6000 -profile Joseph S. Myers
2011-01-14 8:57 ` Nathan Sidwell
2011-01-26 18:26 ` Ping " Joseph S. Myers
2011-01-27 19:13 ` Krister Walfridsson
2011-01-14 0:19 ` [19/25] Specs cleanup: SPARC -mcpu aliases Joseph S. Myers
2011-01-14 9:20 ` Eric Botcazou
2011-01-15 21:29 ` Eric Botcazou
2011-01-14 0:20 ` [21/25] Specs cleanup: SPU Joseph S. Myers
2011-01-17 17:06 ` Ulrich Weigand
2011-01-25 23:12 ` Joseph S. Myers
2011-01-27 9:23 ` Ulrich Weigand [this message]
2011-01-14 0:20 ` [20/25] Specs cleanup: SPARC -sun4 -target Joseph S. Myers
2011-01-14 9:21 ` Eric Botcazou
2011-01-14 0:21 ` [22/25] Specs cleanup: -msse5 Joseph S. Myers
2011-01-14 10:40 ` Richard Guenther
2011-01-14 0:23 ` [23/25] Specs cleanup: -YP, Joseph S. Myers
2011-01-26 18:29 ` Ping " Joseph S. Myers
2011-01-26 19:37 ` Richard Guenther
2011-01-14 0:50 ` [24/25] Specs cleanup: -Ym, Joseph S. Myers
2011-01-14 9:44 ` Eric Botcazou
2011-01-26 18:40 ` Ping " Joseph S. Myers
2011-01-26 19:40 ` Richard Guenther
2011-01-14 0:56 ` [25/25] Specs cleanup: -Qn/-Qy Joseph S. Myers
2011-01-14 9:45 ` Eric Botcazou
2011-01-26 18:55 ` Ping " Joseph S. Myers
2011-01-26 19:44 ` Richard Guenther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101270841.p0R8feuX023190@d06av02.portsmouth.uk.ibm.com \
--to=uweigand@de.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=trevor_smigiel@playstation.sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).