From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15473 invoked by alias); 3 Feb 2011 16:20:53 -0000 Received: (qmail 15462 invoked by uid 22791); 3 Feb 2011 16:20:51 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Feb 2011 16:20:47 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id p13GKjml014968 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 3 Feb 2011 11:20:45 -0500 Received: from tyan-ft48-01.lab.bos.redhat.com (tyan-ft48-01.lab.bos.redhat.com [10.16.42.4]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p13GKgQC030643 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 3 Feb 2011 11:20:44 -0500 Received: from tyan-ft48-01.lab.bos.redhat.com (localhost.localdomain [127.0.0.1]) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4) with ESMTP id p13GKf2l027670; Thu, 3 Feb 2011 17:20:41 +0100 Received: (from jakub@localhost) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4/Submit) id p13GKfSi027665; Thu, 3 Feb 2011 17:20:41 +0100 Date: Thu, 03 Feb 2011 16:20:00 -0000 From: Jakub Jelinek To: Richard Henderson Cc: Jeff Law , Richard Guenther , gcc-patches@gcc.gnu.org Subject: Re: Patch ping Message-ID: <20110203162041.GS30899@tyan-ft48-01.lab.bos.redhat.com> Reply-To: Jakub Jelinek References: <20110203115855.GR30899@tyan-ft48-01.lab.bos.redhat.com> <4D4AD45F.7060008@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D4AD45F.7060008@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-02/txt/msg00209.txt.bz2 On Thu, Feb 03, 2011 at 08:14:23AM -0800, Richard Henderson wrote: > On 02/03/2011 03:58 AM, Jakub Jelinek wrote: > > The following patch is awaiting review for a week: > > > > - http://gcc.gnu.org/ml/gcc-patches/2011-01/msg02059.html > > P1 PR31490, section flags conflict handling > > I think the second patch, attempting to keep the warnings in declaration order, > is better. I don't think there's so much extra work to warrant the inconsistency. Thanks. > One change though, > > > /* Private flag applied to disable section-anchors in a particular section. > > This needs to be kept in sync with the flags used by varasm.c (defined in > > output.h). */ > > -#define SECTION_NO_ANCHOR 0x2000000 > > +#define SECTION_NO_ANCHOR 0x4000000 > > That ought to have been defined as (SECTION_MACH_DEP << 1). That does leave > the comment slightly out of date -- "other machine-dependent uses" perhaps? Well, it perhaps could be just SECTION_MACH_DEP, at least I can't see any reasons why it couldn't, just the assert required that it was bigger: config/darwin.c: gcc_assert (SECTION_NO_ANCHOR > SECTION_MACH_DEP); config/alpha/alpha.c:#define SECTION_PUBLIC SECTION_MACH_DEP config/i386/winnt.c:#define SECTION_PE_SHARED SECTION_MACH_DEP config/ia64/ia64.c:#define SECTION_VMS_OVERLAY SECTION_MACH_DEP config/mep/mep.c:#define SECTION_MEP_VLIW SECTION_MACH_DEP darwin doesn't support alpha/ia64/mep (I hope) and is not winnt. I just can't test it on Darwin. Jakub