From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16243 invoked by alias); 3 Feb 2011 16:38:56 -0000 Received: (qmail 16234 invoked by uid 22791); 3 Feb 2011 16:38:55 -0000 X-SWARE-Spam-Status: No, hits=-5.6 required=5.0 tests=AWL,BAYES_00,KAM_STOCKGEN,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Feb 2011 16:38:49 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p13GcmdL011767 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 3 Feb 2011 11:38:48 -0500 Received: from tyan-ft48-01.lab.bos.redhat.com (tyan-ft48-01.lab.bos.redhat.com [10.16.42.4]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p13Gcjx6019163 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 3 Feb 2011 11:38:47 -0500 Received: from tyan-ft48-01.lab.bos.redhat.com (localhost.localdomain [127.0.0.1]) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4) with ESMTP id p13Gcj0H032173; Thu, 3 Feb 2011 17:38:45 +0100 Received: (from jakub@localhost) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4/Submit) id p13GciPT032172; Thu, 3 Feb 2011 17:38:44 +0100 Date: Thu, 03 Feb 2011 16:38:00 -0000 From: Jakub Jelinek To: Richard Henderson Cc: IainS , Jeff Law , Richard Guenther , gcc-patches@gcc.gnu.org Subject: Re: Patch ping Message-ID: <20110203163844.GT30899@tyan-ft48-01.lab.bos.redhat.com> Reply-To: Jakub Jelinek References: <20110203115855.GR30899@tyan-ft48-01.lab.bos.redhat.com> <4D4AD45F.7060008@redhat.com> <20110203162041.GS30899@tyan-ft48-01.lab.bos.redhat.com> <23E2F999-12EC-4569-98DA-0A542A17FEF1@sandoe-acoustics.co.uk> <4D4AD757.90308@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D4AD757.90308@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-02/txt/msg00219.txt.bz2 On Thu, Feb 03, 2011 at 08:27:03AM -0800, Richard Henderson wrote: > On 02/03/2011 08:24 AM, IainS wrote: > >> Well, it perhaps could be just SECTION_MACH_DEP, at least I can't see any > >> reasons why it couldn't, just the assert required that it was bigger: > > > > hmm, > > won't that output.h to be before every instance of darwin.h? > > No, just so long as it's included before SECTION_NO_ANCHOR is used. > What's in darwin.h is merely a macro definition, not a "real" use. Well, I see no reason why SECTION_NO_ANCHOR could not be defined in config/darwin.c instead. It is used just in config/darwin.c and config/darwin-sections.def. While the latter is included by both config/darwin.c and config/darwin.h, in darwin.h only the NAME from it matters. So something like (separate patch, if you want to test it together with the PR31490 patch just remove the config/darwin.h hunk from the PR31490 patch): 2011-02-03 Jakub Jelinek * config/darwin.h (SECTION_NO_ANCHOR): Remove. * config/darwin.c (SECTION_NO_ANCHOR): Define. (darwin_init_sections): Remove assertion. --- gcc/config/darwin.c.jj 2011-01-15 11:26:39.411777352 +0100 +++ gcc/config/darwin.c 2011-02-03 17:35:15.074388782 +0100 @@ -160,6 +160,11 @@ output_objc_section_asm_op (const void * output_section_asm_op (directive); } + +/* Private flag applied to disable section-anchors in a particular section. */ +#define SECTION_NO_ANCHOR SECTION_MACH_DEP + + /* Implement TARGET_ASM_INIT_SECTIONS. */ void @@ -177,10 +182,6 @@ darwin_init_sections (void) readonly_data_section = darwin_sections[const_section]; exception_section = darwin_sections[darwin_exception_section]; eh_frame_section = darwin_sections[darwin_eh_frame_section]; - - /* Make sure that there is no conflict between the 'no anchor' section - flag declared in darwin.h and the section flags declared in output.h. */ - gcc_assert (SECTION_NO_ANCHOR > SECTION_MACH_DEP); } int --- gcc/config/darwin.h.jj 2011-01-28 20:34:16.455652744 +0100 +++ gcc/config/darwin.h 2011-02-03 17:33:25.676670013 +0100 @@ -651,11 +651,6 @@ int darwin_label_is_anonymous_local_objc /* The generic version, archs should over-ride where required. */ #define MACHOPIC_NL_SYMBOL_PTR_SECTION ".non_lazy_symbol_pointer" -/* Private flag applied to disable section-anchors in a particular section. - This needs to be kept in sync with the flags used by varasm.c (defined in - output.h). */ -#define SECTION_NO_ANCHOR 0x2000000 - /* Declare the section variables. */ #ifndef USED_FOR_TARGET enum darwin_section_enum { Jakub