From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18892 invoked by alias); 23 Feb 2011 09:12:33 -0000 Received: (qmail 18884 invoked by uid 22791); 23 Feb 2011 09:12:31 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 23 Feb 2011 09:12:27 +0000 Received: by mel.act-europe.fr (Postfix, from userid 546) id 64CCBCB0223; Wed, 23 Feb 2011 10:12:25 +0100 (CET) Date: Wed, 23 Feb 2011 10:56:00 -0000 From: Olivier Hainque To: Jason Merrill Cc: Joel Brobecker , gcc-patches@gcc.gnu.org, guitton@adacore.com, hainque@adacore.com Subject: Re: [PING #5] add support for dwarf AT_descriptive_type Message-ID: <20110223091225.GB15008@mel.act-europe.fr> References: <20100902143849.GA23684@cardhu.act-europe.fr> <20110218034841.GA20653@adacore.com> <4D61C9A6.4070605@redhat.com> <20110222172416.GE19066@mel.act-europe.fr> <4D645EC1.4020209@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D645EC1.4020209@redhat.com> User-Agent: Mutt/1.5.16 (2007-06-09) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-02/txt/msg01523.txt.bz2 Jason Merrill wrote: > Turning it into a regular langhook is definitely the way to go, but I > think I'd prefer to leave it clearly GNAT-specific (and documented as > something that ought to be replaced with a better solution). OK, reworking accordingly. Actually, the langhook doesn't quite generate the attribute, but provides the type that the attribute designates. One possible way to present that is then to revert to an explicitly GNAT specific attribute, leave the langhook name untouched and document that it's only used by the Ada front-end for a GNAT specific attribute support. Would something along those lines work for you ? Olivier