From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6175 invoked by alias); 3 Mar 2011 21:30:20 -0000 Received: (qmail 6165 invoked by uid 22791); 3 Mar 2011 21:30:20 -0000 X-SWARE-Spam-Status: No, hits=-6.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 03 Mar 2011 21:30:12 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p23LUBBd017000 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 3 Mar 2011 16:30:11 -0500 Received: from tyan-ft48-01.lab.bos.redhat.com (tyan-ft48-01.lab.bos.redhat.com [10.16.42.4]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p23LUAYu001400 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 3 Mar 2011 16:30:11 -0500 Received: from tyan-ft48-01.lab.bos.redhat.com (localhost.localdomain [127.0.0.1]) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4) with ESMTP id p23LU97Y026183; Thu, 3 Mar 2011 22:30:10 +0100 Received: (from jakub@localhost) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4/Submit) id p23LU8RR025836; Thu, 3 Mar 2011 22:30:08 +0100 Date: Thu, 03 Mar 2011 21:30:00 -0000 From: Jakub Jelinek To: Michael Snyder Cc: "dj@redhat.com" , "gdb-patches@sourceware.org" , "gcc-patches@gcc.gnu.org" Subject: Re: libiberty/cplus-dem.c, ada-demangle: plug memory leak. Message-ID: <20110303213008.GY30899@tyan-ft48-01.lab.bos.redhat.com> Reply-To: Jakub Jelinek References: <4D70061C.10904@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D70061C.10904@vmware.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-03/txt/msg00153.txt.bz2 On Thu, Mar 03, 2011 at 01:20:28PM -0800, Michael Snyder wrote: > 2011-03-03 Michael Snyder > > * libiberty/cplus-dem.c (ada_demangle): Stop memory leak. > Also fix a one line indent problem. No libiberty/ in libiberty/ChangeLog. > @@ -1129,10 +1129,11 @@ ada_demangle (const char *mangled, int o > > unknown: > len0 = strlen (mangled); > + xfree (demangled); > demangled = XNEWVEC (char, len0 + 3); xfree isn't ever used in libiberty/*, use either free, or XDELETE/XDELETEVEC. In fact, it seems to be defined only in gdb, making cplus-dem.c dependent on gdb is obviously a wrong thing. Jakub