From: Jakub Jelinek <jakub@redhat.com>
To: Richard Guenther <richard.guenther@gmail.com>
Cc: gcc-patches@gcc.gnu.org, patches@linaro.org,
richard.sandiford@linaro.org
Subject: Re: [2/2] Reducing the overhead of dwarf2 location tracking
Date: Fri, 04 Mar 2011 15:10:00 -0000 [thread overview]
Message-ID: <20110304151007.GG30899@tyan-ft48-01.lab.bos.redhat.com> (raw)
In-Reply-To: <AANLkTinnK8-g-VVFC+cfGaaaOKM_9h-9SUkbFLLmK8BH@mail.gmail.com>
On Fri, Mar 04, 2011 at 04:00:06PM +0100, Richard Guenther wrote:
> But then location lists for those variables depend on the function context
> and cannot be shared for different callers. Am I missing something?
Sure, they can't be shared between different functions. If Richard's patch
does that, it is wrong.
> Likewise I don't see how they could be shared for multiple inline instances
> in the same function.
But there is no reason why it can't be shared within one function, across
many inline instances. There is just a single nonlocalized decl in all
those cases you cache, and even if it appears in multiple BLOCKs
BLOCK_NONLOCALIZED_VARS, VAR_LOCATION notes referencing it are still
all queued for that DECL_UID from the whole function and any time you
want to create a location list from what has been queued in the VAR_LOCATION
notes, you will get the same list.
Jakub
next prev parent reply other threads:[~2011-03-04 15:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-04 13:57 Richard Sandiford
2011-03-04 14:30 ` Richard Guenther
2011-03-04 14:47 ` Richard Sandiford
2011-03-04 14:50 ` Jakub Jelinek
2011-03-04 15:00 ` Richard Guenther
2011-03-04 15:10 ` Jakub Jelinek [this message]
2011-03-04 15:15 ` Richard Guenther
2011-03-04 15:48 ` Richard Sandiford
2011-03-04 15:22 ` Jakub Jelinek
2011-03-05 14:38 ` Richard Sandiford
2011-03-28 9:00 ` Matthias Klose
2011-04-04 10:50 ` Richard Sandiford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110304151007.GG30899@tyan-ft48-01.lab.bos.redhat.com \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=patches@linaro.org \
--cc=richard.guenther@gmail.com \
--cc=richard.sandiford@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).