From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25443 invoked by alias); 11 Mar 2011 14:04:52 -0000 Received: (qmail 25432 invoked by uid 22791); 11 Mar 2011 14:04:51 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Mar 2011 14:04:46 +0000 Received: (qmail 640 invoked from network); 11 Mar 2011 14:04:45 -0000 Received: from unknown (HELO localhost) (froydnj@127.0.0.2) by mail.codesourcery.com with ESMTPA; 11 Mar 2011 14:04:45 -0000 Date: Fri, 11 Mar 2011 14:04:00 -0000 From: Nathan Froyd To: Jason Merrill Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 15/18] move REAL_IDENTIFIER_TYPE_VALUE to be a field of lang_identifier Message-ID: <20110311140444.GI23686@codesourcery.com> References: <1299817406-16745-1-git-send-email-froydnj@codesourcery.com> <1299817406-16745-16-git-send-email-froydnj@codesourcery.com> <4D7A2648.40005@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D7A2648.40005@redhat.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-03/txt/msg00608.txt.bz2 On Fri, Mar 11, 2011 at 08:40:24AM -0500, Jason Merrill wrote: > On 03/10/2011 11:23 PM, Nathan Froyd wrote: >> I'm not overly fond of the conditionals (especially in error_operand_p) >> but I don't think it's reasonable to make IDENTIFIER_NODE bigger and >> penalize the other FEs just because the C++ FE is playing games with >> TREE_TYPE. > > The C++ FE expects that we can check the TREE_TYPE of anything that > appears as an expression, and uses IDENTIFIER_NODE to indicate a > dependent name within templates. If you want to break TREE_TYPE on > IDENTIFIER_NODE, you need to change the representation of dependent > names so that we can continue to use TREE_TYPE on all expressions. I'm confused. Isn't this what the switching on IDENTIFIER_NODE in a number of places is doing? (And any future places that g++/libstdc++ didn't catch will be an ICE.) Or are you saying that you don't want the switching and IDENTIFIER_NODEs should retain TREE_TYPE unless and until somebody comes forth with a better design? -Nathan