From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27324 invoked by alias); 11 Mar 2011 17:21:52 -0000 Received: (qmail 27309 invoked by uid 22791); 11 Mar 2011 17:21:50 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Mar 2011 17:21:46 +0000 Received: (qmail 29048 invoked from network); 11 Mar 2011 17:21:44 -0000 Received: from unknown (HELO localhost) (froydnj@127.0.0.2) by mail.codesourcery.com with ESMTPA; 11 Mar 2011 17:21:44 -0000 Date: Fri, 11 Mar 2011 17:21:00 -0000 From: Nathan Froyd To: Richard Guenther Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 16/18] make TS_IDENTIFIER be a substructure of TS_BASE Message-ID: <20110311172143.GN23686@codesourcery.com> References: <1299817406-16745-1-git-send-email-froydnj@codesourcery.com> <1299817406-16745-17-git-send-email-froydnj@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.17+20080114 (2008-01-14) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-03/txt/msg00650.txt.bz2 On Fri, Mar 11, 2011 at 02:12:06PM +0100, Richard Guenther wrote: > On Fri, Mar 11, 2011 at 5:23 AM, Nathan Froyd wrote: > > Now that we've done the requisite surgery on the C++ FE, we can > > eliminate TREE_CHAIN and TREE_TYPE from IDENTIFIER_NODEs.  Doing so > > turns up a couple different places that need to be tweaked. > > At some point we should zero-out DECL/TYPE_LANG_SPECIFIC, I > don't remember why we don't do that. > > The patch is ok for 4.7 anyway. Given Jason's comments on patch 15/18, I'll be dropping chunks of this and just eliminating TREE_CHAIN from IDENTIFIER_NODEs for now. Since those changes are trivial, I'm going to assume I don't need separate approval for those (appropriate testing will of course be performed). -Nathan