From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16677 invoked by alias); 12 Mar 2011 12:13:19 -0000 Received: (qmail 16651 invoked by uid 22791); 12 Mar 2011 12:13:17 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 12 Mar 2011 12:13:11 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 8E2C0CB023D; Sat, 12 Mar 2011 13:13:09 +0100 (CET) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ZEtozleBq7+d; Sat, 12 Mar 2011 13:13:06 +0100 (CET) Received: from [192.168.1.2] (bon31-9-83-155-120-49.fbx.proxad.net [83.155.120.49]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id 811A4CB01F0; Sat, 12 Mar 2011 13:13:06 +0100 (CET) From: Eric Botcazou To: Nathan Froyd Subject: Re: [PATCH 02/18] enforce TREE_CHAIN and TREE_TYPE accesses Date: Sat, 12 Mar 2011 12:13:00 -0000 User-Agent: KMail/1.9.9 Cc: gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org, java-patches@gcc.gnu.org References: <1299817406-16745-1-git-send-email-froydnj@codesourcery.com> <1299817406-16745-3-git-send-email-froydnj@codesourcery.com> In-Reply-To: <1299817406-16745-3-git-send-email-froydnj@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <201103121308.24092.ebotcazou@adacore.com> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-03/txt/msg00673.txt.bz2 > gcc/ada/ > * gcc-interface/ada-tree.h (union lang_tree_node): Check for > TS_COMMON before calling TREE_CHAIN. > * gcc-interface/misc.c (gnat_init_ts): New function. > (LANG_HOOKS_INIT_TS): Define. I presume that PLUS_NOMOD_EXPR, MINUS_NOMOD_EXPR and ATTR_ADDR_EXPR need not be marked in gnat_init_ts? If so, please add a single comment to that effect in the function and reorder the lines to match the order in ada-tree.def. OK with these changes. -- Eric Botcazou