From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10384 invoked by alias); 21 Mar 2011 13:50:23 -0000 Received: (qmail 10376 invoked by uid 22791); 21 Mar 2011 13:50:21 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 21 Mar 2011 13:50:17 +0000 Received: (qmail 6195 invoked from network); 21 Mar 2011 13:50:15 -0000 Received: from unknown (HELO localhost) (froydnj@127.0.0.2) by mail.codesourcery.com with ESMTPA; 21 Mar 2011 13:50:15 -0000 Date: Mon, 21 Mar 2011 13:50:00 -0000 From: Nathan Froyd To: Eric Botcazou Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 02/18] enforce TREE_CHAIN and TREE_TYPE accesses Message-ID: <20110321135015.GH30619@codesourcery.com> References: <1299817406-16745-1-git-send-email-froydnj@codesourcery.com> <1299817406-16745-3-git-send-email-froydnj@codesourcery.com> <201103121308.24092.ebotcazou@adacore.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201103121308.24092.ebotcazou@adacore.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-03/txt/msg01296.txt.bz2 On Sat, Mar 12, 2011 at 01:08:23PM +0100, Eric Botcazou wrote: > > gcc/ada/ > > * gcc-interface/ada-tree.h (union lang_tree_node): Check for > > TS_COMMON before calling TREE_CHAIN. > > * gcc-interface/misc.c (gnat_init_ts): New function. > > (LANG_HOOKS_INIT_TS): Define. > > I presume that PLUS_NOMOD_EXPR, MINUS_NOMOD_EXPR and ATTR_ADDR_EXPR need not > be marked in gnat_init_ts? If so, please add a single comment to that effect > in the function and reorder the lines to match the order in ada-tree.def. Well, they never have their TREE_TYPE taken during bootstrap and test, at least... You're right, though; they should probably be marked as such for completeness. OK to commit with those additions and reordering as above sight unseen, or would you like to see the patch? -Nathan