From: Nathan Froyd <froydnj@codesourcery.com>
To: Jeff Law <law@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] cleanup gcse.c:canon_modify_mem_list
Date: Tue, 05 Apr 2011 11:44:00 -0000 [thread overview]
Message-ID: <20110405114440.GE23480@codesourcery.com> (raw)
In-Reply-To: <4D9A0765.6020901@redhat.com>
On Mon, Apr 04, 2011 at 12:01:09PM -0600, Jeff Law wrote:
> > + canon_modify_mem_list = GCNEWVEC (VEC(modify_pair,heap) *,
> > + last_basic_block);
> nit; You're missing some whitespace here (after the VEC).
This doesn't seem to be a hard-and-fast policy; all of the VEC code I
remember writing or looking at recently has no spaces, and I checked the
patch in on that basis. However, running grep indicates that we have a
profusion of styles...
-Nathan
next prev parent reply other threads:[~2011-04-05 11:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 1:45 Nathan Froyd
2011-04-04 18:01 ` Jeff Law
2011-04-05 11:44 ` Nathan Froyd [this message]
2011-04-05 12:22 ` Richard Earnshaw
2011-04-05 12:30 ` Nathan Froyd
2011-04-05 12:55 ` Richard Earnshaw
2011-04-05 13:08 ` Jeff Law
2011-04-05 14:40 ` Richard Earnshaw
2011-04-05 18:10 ` Mike Stump
2011-04-05 19:18 ` Joseph S. Myers
2011-04-05 19:51 ` Nathan Froyd
2011-04-05 16:19 ` Jeff Law
2011-04-04 15:42 Steven Bosscher
2011-04-04 15:50 ` Nathan Froyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110405114440.GE23480@codesourcery.com \
--to=froydnj@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).