From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29736 invoked by alias); 5 Apr 2011 11:44:47 -0000 Received: (qmail 29727 invoked by uid 22791); 5 Apr 2011 11:44:46 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Apr 2011 11:44:42 +0000 Received: (qmail 6618 invoked from network); 5 Apr 2011 11:44:41 -0000 Received: from unknown (HELO localhost) (froydnj@127.0.0.2) by mail.codesourcery.com with ESMTPA; 5 Apr 2011 11:44:41 -0000 Date: Tue, 05 Apr 2011 11:44:00 -0000 From: Nathan Froyd To: Jeff Law Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] cleanup gcse.c:canon_modify_mem_list Message-ID: <20110405114440.GE23480@codesourcery.com> References: <20110404014451.GA16239@nightcrawler> <4D9A0765.6020901@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4D9A0765.6020901@redhat.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg00317.txt.bz2 On Mon, Apr 04, 2011 at 12:01:09PM -0600, Jeff Law wrote: > > + canon_modify_mem_list = GCNEWVEC (VEC(modify_pair,heap) *, > > + last_basic_block); > nit; You're missing some whitespace here (after the VEC). This doesn't seem to be a hard-and-fast policy; all of the VEC code I remember writing or looking at recently has no spaces, and I checked the patch in on that basis. However, running grep indicates that we have a profusion of styles... -Nathan