From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22255 invoked by alias); 5 Apr 2011 12:30:50 -0000 Received: (qmail 22242 invoked by uid 22791); 5 Apr 2011 12:30:49 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Apr 2011 12:30:45 +0000 Received: (qmail 22087 invoked from network); 5 Apr 2011 12:30:44 -0000 Received: from unknown (HELO localhost) (froydnj@127.0.0.2) by mail.codesourcery.com with ESMTPA; 5 Apr 2011 12:30:44 -0000 Date: Tue, 05 Apr 2011 12:30:00 -0000 From: Nathan Froyd To: Richard Earnshaw Cc: Jeff Law , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] cleanup gcse.c:canon_modify_mem_list Message-ID: <20110405123041.GG23480@codesourcery.com> References: <20110404014451.GA16239@nightcrawler> <4D9A0765.6020901@redhat.com> <20110405114440.GE23480@codesourcery.com> <1302006159.25036.12.camel@e102346-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1302006159.25036.12.camel@e102346-lin.cambridge.arm.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg00326.txt.bz2 On Tue, Apr 05, 2011 at 01:22:39PM +0100, Richard Earnshaw wrote: > On Tue, 2011-04-05 at 04:44 -0700, Nathan Froyd wrote: > > > nit; You're missing some whitespace here (after the VEC). > > > > This doesn't seem to be a hard-and-fast policy; all of the VEC code I > > remember writing or looking at recently has no spaces, and I checked the > > patch in on that basis. However, running grep indicates that we have a > > profusion of styles... > > I think the style guide is quite clear on this: there should be a space > there as Jeff says. The fact that some code has crept in with other > styles doesn't make them right, or give justification for ignoring the > style guide. Would you like a patch for the hundreds of instances without spaces? Certainly vec.h never uses spaces; I thought this was simply The Way Things Were. -Nathan