From: Nathan Froyd <froydnj@codesourcery.com>
To: Michael Matz <matz@suse.de>
Cc: Steven Bosscher <stevenb.gcc@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] make LABEL_DECL has its own rtx field for its associated CODE_LABEL
Date: Tue, 05 Apr 2011 16:21:00 -0000 [thread overview]
Message-ID: <20110405162130.GI23480@codesourcery.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1104051736460.19760@wotan.suse.de>
On Tue, Apr 05, 2011 at 05:55:33PM +0200, Michael Matz wrote:
> I have a preference in having just one DECL_RTL field for conceptual
> reasons:
>
> Most DECLs are actually objects (there are some prominent exceptions, but
> those always would be better described with something like NAMED_ENTITY,
> if we had something like that, namespaces and translation_unit would
> qualify). All these have a RTL representation, so one field for them
> seems appropriate. That some of those don't have a size (either because
> size makes no sense or is always available via type size) hints towards a
> problem in the inheritance. I would think it should look like so:
>
> decl_common {} # no size, no rtl, no align, no pt_uid
> decl_with_rtl : decl_common {
> # add rtl, align, pt_uid
> }
> decl_with_size : decl_with_rtl {
> # add size, size_unit
> }
>
> Then decl_common can still be used for
> imported_decl/namespace/translation_unit; objects
> are at least decl_with_rtl, and some objects will be decl_with_size.
This is what I was heading for, but I hadn't fully worked out how to
switch around the inheritance structure. Thanks!
Consider this patch dropped, then; I'll work towards something like the
above instead.
-Nathan
next prev parent reply other threads:[~2011-04-05 16:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 15:52 Steven Bosscher
2011-04-04 16:00 ` Nathan Froyd
2011-04-05 15:55 ` Michael Matz
2011-04-05 16:21 ` Nathan Froyd [this message]
2011-04-19 22:31 ` Nathan Froyd
2011-04-20 9:18 ` Richard Guenther
2011-04-21 16:34 ` Michael Matz
2011-04-21 17:19 ` Nathan Froyd
-- strict thread matches above, loose matches on Subject: below --
2011-04-04 1:59 Nathan Froyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110405162130.GI23480@codesourcery.com \
--to=froydnj@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=matz@suse.de \
--cc=stevenb.gcc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).