public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Nathan Froyd <froydnj@codesourcery.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: Richard Earnshaw <rearnsha@arm.com>, Jeff Law <law@redhat.com>,
	gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] cleanup gcse.c:canon_modify_mem_list
Date: Tue, 05 Apr 2011 19:51:00 -0000	[thread overview]
Message-ID: <20110405195141.GM23480@codesourcery.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1104051910040.650@digraph.polyomino.org.uk>

On Tue, Apr 05, 2011 at 07:18:16PM +0000, Joseph S. Myers wrote:
> On Tue, 5 Apr 2011, Nathan Froyd wrote:
> > Certainly vec.h never uses spaces; I thought this was simply The Way
> > Things Were.
> 
> I also had the impression that for certain special macros such as VEC, 
> GTY, _, N_, G_ - macros that are not really substituting for functions, 
> for-loops, etc. - the norm was no space, whereas for function prototypes, 
> function calls and calls to macros that are being used syntactically and 
> semantically more or less like functions the norm is to have the space 
> (I'm not sure about the case of __attribute__ and macros generating 
> __attribute__).  But I see VEC is in fact used more often with the space.  

To be pedantic: grepping for 'VEC (' in gcc/ gives ~1750 hits.  But a
number of those are the X*VEC allocation functions and things like
CLASSTYPE_METHOD_VEC; cutting those out ("fgrep 'VEC (' | egrep -v
'[A-Z][A-Z_]+VEC ('") or similar gives a bit over 800 VEC instances that
use spaces.

grepping for 'VEC(' gives 1300+ hits.  That's a lot of creeping laxity. :)

-Nathan

  reply	other threads:[~2011-04-05 19:51 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-04  1:45 Nathan Froyd
2011-04-04 18:01 ` Jeff Law
2011-04-05 11:44   ` Nathan Froyd
2011-04-05 12:22     ` Richard Earnshaw
2011-04-05 12:30       ` Nathan Froyd
2011-04-05 12:55         ` Richard Earnshaw
2011-04-05 13:08           ` Jeff Law
2011-04-05 14:40             ` Richard Earnshaw
2011-04-05 18:10           ` Mike Stump
2011-04-05 19:18         ` Joseph S. Myers
2011-04-05 19:51           ` Nathan Froyd [this message]
2011-04-05 16:19     ` Jeff Law
2011-04-04 15:42 Steven Bosscher
2011-04-04 15:50 ` Nathan Froyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110405195141.GM23480@codesourcery.com \
    --to=froydnj@codesourcery.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=joseph@codesourcery.com \
    --cc=law@redhat.com \
    --cc=rearnsha@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).