From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18842 invoked by alias); 5 Apr 2011 19:51:50 -0000 Received: (qmail 18834 invoked by uid 22791); 5 Apr 2011 19:51:49 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 05 Apr 2011 19:51:45 +0000 Received: (qmail 10880 invoked from network); 5 Apr 2011 19:51:42 -0000 Received: from unknown (HELO localhost) (froydnj@127.0.0.2) by mail.codesourcery.com with ESMTPA; 5 Apr 2011 19:51:42 -0000 Date: Tue, 05 Apr 2011 19:51:00 -0000 From: Nathan Froyd To: "Joseph S. Myers" Cc: Richard Earnshaw , Jeff Law , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] cleanup gcse.c:canon_modify_mem_list Message-ID: <20110405195141.GM23480@codesourcery.com> References: <20110404014451.GA16239@nightcrawler> <4D9A0765.6020901@redhat.com> <20110405114440.GE23480@codesourcery.com> <1302006159.25036.12.camel@e102346-lin.cambridge.arm.com> <20110405123041.GG23480@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17+20080114 (2008-01-14) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg00397.txt.bz2 On Tue, Apr 05, 2011 at 07:18:16PM +0000, Joseph S. Myers wrote: > On Tue, 5 Apr 2011, Nathan Froyd wrote: > > Certainly vec.h never uses spaces; I thought this was simply The Way > > Things Were. > > I also had the impression that for certain special macros such as VEC, > GTY, _, N_, G_ - macros that are not really substituting for functions, > for-loops, etc. - the norm was no space, whereas for function prototypes, > function calls and calls to macros that are being used syntactically and > semantically more or less like functions the norm is to have the space > (I'm not sure about the case of __attribute__ and macros generating > __attribute__). But I see VEC is in fact used more often with the space. To be pedantic: grepping for 'VEC (' in gcc/ gives ~1750 hits. But a number of those are the X*VEC allocation functions and things like CLASSTYPE_METHOD_VEC; cutting those out ("fgrep 'VEC (' | egrep -v '[A-Z][A-Z_]+VEC ('") or similar gives a bit over 800 VEC instances that use spaces. grepping for 'VEC(' gives 1300+ hits. That's a lot of creeping laxity. :) -Nathan