From: Jakub Jelinek <jakub@redhat.com>
To: Nathan Froyd <froydnj@codesourcery.com>
Cc: Jason Merrill <jason@redhat.com>,
Richard Henderson <rth@redhat.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix LTO bootstrap on i686-linux (problem with two Ldebug_info0 labels; PR bootstrap/48148)
Date: Tue, 05 Apr 2011 21:11:00 -0000 [thread overview]
Message-ID: <20110405211046.GE17079@tyan-ft48-01.lab.bos.redhat.com> (raw)
In-Reply-To: <20110405210614.GO23480@codesourcery.com>
On Tue, Apr 05, 2011 at 02:06:14PM -0700, Nathan Froyd wrote:
> On Tue, Apr 05, 2011 at 04:19:39PM +0200, Jakub Jelinek wrote:
> > + for (i = 0; i < VEC_length (deferred_locations, deferred_locations_list); i++)
> > + {
> > + add_location_or_const_value_attribute (
> > + VEC_index (deferred_locations, deferred_locations_list, i)->die,
> > + VEC_index (deferred_locations, deferred_locations_list, i)->variable,
> > + false,
> > + DW_AT_location);
> > + }
>
> Tiny, non-binding suggestion: use FOR_EACH_VEC_ELT here?
Feel free to do that afterwards, while diff decided to include that
part of code in the patch, it wasn't actually changing at all, what changed
was that the code afterwards was moved into a separate function
and the length of the code being moved probably was bigger than
length from dwarf2out_finish start to that point.
Jakub
next prev parent reply other threads:[~2011-04-05 21:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-05 14:19 Jakub Jelinek
2011-04-05 21:06 ` Nathan Froyd
2011-04-05 21:11 ` Jakub Jelinek [this message]
2011-04-08 17:58 ` Jason Merrill
2011-04-08 19:11 ` Jakub Jelinek
2011-04-08 21:13 ` Richard Guenther
2011-04-08 21:41 ` Michael Matz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110405211046.GE17079@tyan-ft48-01.lab.bos.redhat.com \
--to=jakub@redhat.com \
--cc=froydnj@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).