From: Basile Starynkevitch <basile@starynkevitch.net>
To: Laurynas Biveinis <laurynas.biveinis@gmail.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: PATCH [trunk] gengtype should generate ggc_alloc macros in plugin mode.
Date: Fri, 08 Apr 2011 17:57:00 -0000 [thread overview]
Message-ID: <20110408195551.4804bbfe.basile@starynkevitch.net> (raw)
In-Reply-To: <BANLkTikD8VUUTi3W-ZCcjB6GTPPF-V=wgA@mail.gmail.com>
On Fri, 8 Apr 2011 15:29:48 +0300
Laurynas Biveinis <laurynas.biveinis@gmail.com> wrote:
> > 2011-04-08 Basile Starynkevitch <basile@starynkevitch.net>
> > * gengtype.c (write_typed_alloc_def): New argument f. Use it instead
> > of header_file.
> > (write_typed_struct_alloc_def, write_typed_typedef_alloc_def)
> > (write_typed_alloc_defns): Likewise.
> > (main): Calls write_typed_alloc_defns with output_header.
>
> The patch is OK. Thanks,
Committed revision 172203 (on trunk).
Actually, the above committed patch is better than nothing, but not
perfect. It happens to generate ggc_alloc macros for things which are
not defined in the plugin (however, this is not a big deal in practice,
since it generates some macros in common with those inside
gtype-desc.h).
I have no clear idea on how to improve it. We could for instance write
the ggc_alloc macros only for struct & typedefs defined in the plugin
files. We then would need a way to know if a file is a plugin file or
not. What do you think?
We might also want to generate the ggc_alloc macros in a header file
(for the plugin) different of the one containing the marking routines.
Cheers
--
Basile STARYNKEVITCH http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mine, sont seulement les miennes} ***
next prev parent reply other threads:[~2011-04-08 17:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-04 19:54 Basile Starynkevitch
2011-04-07 2:46 ` Laurynas Biveinis
2011-04-08 5:46 ` Basile Starynkevitch
2011-04-08 6:22 ` Duncan Sands
2011-04-08 12:30 ` Laurynas Biveinis
2011-04-08 17:57 ` Basile Starynkevitch [this message]
2011-04-10 18:47 ` Laurynas Biveinis
2011-04-10 18:51 ` Basile Starynkevitch
2011-04-11 1:37 ` PATCH [trunk] gengtype should generate ggc_alloc macros in plugin mode on for plugin files Basile Starynkevitch
2011-04-15 4:24 ` Laurynas Biveinis
2011-04-15 7:26 ` Basile Starynkevitch
2011-04-19 7:13 ` Laurynas Biveinis
2011-04-19 10:12 ` Basile Starynkevitch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110408195551.4804bbfe.basile@starynkevitch.net \
--to=basile@starynkevitch.net \
--cc=gcc-patches@gcc.gnu.org \
--cc=laurynas.biveinis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).