From: Basile Starynkevitch <basile@starynkevitch.net>
To: dnovillo@google.com
Cc: gcc-patches@gcc.gnu.org
Subject: Ping Patch: add {tree,gimple}-pretty-print.h & realmpfr.h to PLUGIN_HEADERS
Date: Mon, 11 Apr 2011 19:25:00 -0000 [thread overview]
Message-ID: <20110411212421.e7c55588.basile@starynkevitch.net> (raw)
In-Reply-To: <20110407214344.5a3afcb3.basile@starynkevitch.net>
[-- Attachment #1: Type: text/plain, Size: 1656 bytes --]
On Thu, 7 Apr 2011 21:43:44 +0200
Basile Starynkevitch <basile@starynkevitch.net> wrote:
> > The following tiny patch add some files to PLUGIN_HEADERS.
###### gcc/ChangeLog entry
2011-04-11 Basile Starynkevitch <basile@starynkevitch.net>
* Makefile.in (PLUGIN_HEADERS): Add gimple-pretty-print.h
tree-pretty-print.h & realmpfr.h.
######
> Some more explanations about why I feel these files are badly needed
> for plugins (not only for MELT as a plugin, but for other plugins).
>
> Pretty printing routines are very useful to help understand, debug, and
> dump any additional passes, so plugin providing passes working on
> Gimple or Tree need the gimple-pretty-print.h & tree-pretty-print.h,
> since to call dumping or debug routines like debug_c_tree or
> print_declaration or dump_gimple_stmt you need to include these files.
> Please consider that people coding plugins know Gimple & Tree much
> less than GCC top level experts, and they are much more likely to
> need debug or dumping routines!
>
> The realmpfr.h file is needed to operate on tree or gimple containing
> real constants. For instance, a plugin to find all occurrences (in
> Gimple) of 3.14159 need it, or also a plugin which constant-fold the
> calls to <math.h> which are not already constant folded in GCC, or a
> plugin which constant-fold calls to some other (but less standard)
> numerical library.
Ok for trunk?
--
Basile STARYNKEVITCH http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mine, sont seulement les miennes} ***
[-- Attachment #2: plugin-headers-gcc-r172124.diff --]
[-- Type: text/x-diff, Size: 556 bytes --]
Index: gcc/Makefile.in
===================================================================
--- gcc/Makefile.in (revision 172124)
+++ gcc/Makefile.in (working copy)
@@ -4534,6 +4534,7 @@
$(EXCEPT_H) tree-ssa-sccvn.h real.h output.h $(IPA_UTILS_H) \
$(C_PRAGMA_H) $(CPPLIB_H) $(FUNCTION_H) \
cppdefault.h flags.h $(MD5_H) params.def params.h prefix.h tree-inline.h \
+ gimple-pretty-print.h tree-pretty-print.h realmpfr.h \
$(IPA_PROP_H) $(RTL_H) $(TM_P_H) $(CFGLOOP_H) $(EMIT_RTL_H) version.h
# generate the 'build fragment' b-header-vars
next prev parent reply other threads:[~2011-04-11 19:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-07 19:42 Basile Starynkevitch
2011-04-07 19:44 ` Basile Starynkevitch
2011-04-11 19:25 ` Basile Starynkevitch [this message]
2011-04-11 19:27 ` Ping " Diego Novillo
2011-04-11 19:33 ` Basile Starynkevitch
2011-04-11 19:34 ` Diego Novillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110411212421.e7c55588.basile@starynkevitch.net \
--to=basile@starynkevitch.net \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).