From: crowl@google.com (Lawrence Crowl)
To: reply@codereview.appspotmail.com, dnovillo@google.com,
gcc-patches@gcc.gnu.org
Subject: [pph] Test PPH include at global scope. (issue4399041)
Date: Tue, 12 Apr 2011 21:40:00 -0000 [thread overview]
Message-ID: <20110412213959.76F58222670@jade.mtv.corp.google.com> (raw)
Add a test to ensure that PPH files are #included at global scope.
Initially, this test is XFAIL, as it's a low priority error.
Index: gcc/testsuite/ChangeLog.pph
2011-04-12 Lawrence Crowl <crowl@google.com>
* g++.dg/pph/y2smother.cc: New.
Index: gcc/testsuite/g++.dg/pph/y2smother.cc
===================================================================
*** gcc/testsuite/g++.dg/pph/y2smother.cc (revision 0)
--- gcc/testsuite/g++.dg/pph/y2smother.cc (revision 0)
***************
*** 0 ****
--- 1,4 ----
+ namespace smother {
+ #include "x1struct1.h"
+ // { dg-error "pph file not included at global scope" "" { xfail *-*-* } }
+ }
--
This patch is available for review at http://codereview.appspot.com/4399041
next reply other threads:[~2011-04-12 21:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-12 21:40 Lawrence Crowl [this message]
2011-04-13 18:17 dnovillo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110412213959.76F58222670@jade.mtv.corp.google.com \
--to=crowl@google.com \
--cc=dnovillo@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=reply@codereview.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).