* [pph] Test PPH include at global scope. (issue4399041)
@ 2011-04-12 21:40 Lawrence Crowl
0 siblings, 0 replies; 2+ messages in thread
From: Lawrence Crowl @ 2011-04-12 21:40 UTC (permalink / raw)
To: reply, dnovillo, gcc-patches
Add a test to ensure that PPH files are #included at global scope.
Initially, this test is XFAIL, as it's a low priority error.
Index: gcc/testsuite/ChangeLog.pph
2011-04-12 Lawrence Crowl <crowl@google.com>
* g++.dg/pph/y2smother.cc: New.
Index: gcc/testsuite/g++.dg/pph/y2smother.cc
===================================================================
*** gcc/testsuite/g++.dg/pph/y2smother.cc (revision 0)
--- gcc/testsuite/g++.dg/pph/y2smother.cc (revision 0)
***************
*** 0 ****
--- 1,4 ----
+ namespace smother {
+ #include "x1struct1.h"
+ // { dg-error "pph file not included at global scope" "" { xfail *-*-* } }
+ }
--
This patch is available for review at http://codereview.appspot.com/4399041
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [pph] Test PPH include at global scope. (issue4399041)
@ 2011-04-13 18:17 dnovillo
0 siblings, 0 replies; 2+ messages in thread
From: dnovillo @ 2011-04-13 18:17 UTC (permalink / raw)
To: crowl; +Cc: gcc-patches, reply
On 2011/04/12 21:40:10, Lawrence Crowl wrote:
> Add a test to ensure that PPH files are #included at global scope.
> Initially, this test is XFAIL, as it's a low priority error.
> Index: gcc/testsuite/ChangeLog.pph
> 2011-04-12 Lawrence Crowl <mailto:crowl@google.com>
> * g++.dg/pph/y2smother.cc: New.
OK.
Diego.
http://codereview.appspot.com/4399041/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-13 18:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-12 21:40 [pph] Test PPH include at global scope. (issue4399041) Lawrence Crowl
2011-04-13 18:17 dnovillo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).