From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21342 invoked by alias); 13 Apr 2011 02:43:47 -0000 Received: (qmail 21324 invoked by uid 22791); 13 Apr 2011 02:43:46 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Apr 2011 02:43:42 +0000 Received: (qmail 21227 invoked from network); 13 Apr 2011 02:43:41 -0000 Received: from unknown (HELO localhost) (froydnj@127.0.0.2) by mail.codesourcery.com with ESMTPA; 13 Apr 2011 02:43:41 -0000 Date: Wed, 13 Apr 2011 02:43:00 -0000 From: Nathan Froyd To: gcc-patches@gcc.gnu.org Cc: iant@google.com, dnovillo@google.com Subject: Re: [PATCH 02/18] enforce TREE_CHAIN and TREE_TYPE accesses Message-ID: <20110413024341.GT23480@codesourcery.com> References: <1299817406-16745-1-git-send-email-froydnj@codesourcery.com> <1299817406-16745-3-git-send-email-froydnj@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1299817406-16745-3-git-send-email-froydnj@codesourcery.com> User-Agent: Mutt/1.5.17+20080114 (2008-01-14) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg00959.txt.bz2 On Thu, Mar 10, 2011 at 11:23:10PM -0500, Nathan Froyd wrote: > Now that we have a structure where not every node might include > TREE_CHAIN or TREE_TYPE, we need to make sure that when we call said > accessors that the argument is properly typed. This requires a number > of changes: http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00565.html Ping. I was going to commit this, but I realized I hadn't received approval for the go or LTO bits. They probably qualify as obvious, given that they're exactly the same as all the other languages, but just to rubber-stamp everything... > gcc/go/ > * go-lang.c (union lang_tree_node): Check for TS_COMMON before > calling TREE_CHAIN. > > gcc/lto/ > * lto-tree.h (union lang_tree_node): Check for TS_COMMON before > calling TREE_CHAIN. > * lto.c (lto_fixup_common): Likewise. Thanks, -Nathan