* [pph] Initialize fields in default ctor for _Hashtable_iterator (issue4430051)
@ 2011-04-16 22:42 Diego Novillo
2011-04-16 22:46 ` [google] " Diego Novillo
0 siblings, 1 reply; 2+ messages in thread
From: Diego Novillo @ 2011-04-16 22:42 UTC (permalink / raw)
To: reply, davidxl, libstdc++, gcc-patches
I am committing this patch for David Li on google/main.
The patch adds explicit initialization to the fields of
_Hashtable_iterator in its default constructor. David, could you
describe why this change was needed? Will you be submitting for
trunk?
Tested on x86_64. Committed to google/main.
Diego.
2011-04-15 Xinliang David Li <davidxl@google.com>
Google ref 43787.
* include/backward/hashtable.h
(_Hashtable_iterator::_Hashtable_iterator): Initialize _M_cur and
_M_ht in default constructor.
diff --git a/libstdc++-v3/include/backward/hashtable.h b/libstdc++-v3/include/backward/hashtable.h
index 0bcaec4..c3eefcc 100644
--- a/libstdc++-v3/include/backward/hashtable.h
+++ b/libstdc++-v3/include/backward/hashtable.h
@@ -126,7 +126,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
_Hashtable_iterator(_Node* __n, _Hashtable* __tab)
: _M_cur(__n), _M_ht(__tab) { }
- _Hashtable_iterator() { }
+ _Hashtable_iterator()
+ : _M_cur(0), _M_ht(0) { }
reference
operator*() const
--
This patch is available for review at http://codereview.appspot.com/4430051
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [google] Initialize fields in default ctor for _Hashtable_iterator (issue4430051)
2011-04-16 22:42 [pph] Initialize fields in default ctor for _Hashtable_iterator (issue4430051) Diego Novillo
@ 2011-04-16 22:46 ` Diego Novillo
0 siblings, 0 replies; 2+ messages in thread
From: Diego Novillo @ 2011-04-16 22:46 UTC (permalink / raw)
To: reply, davidxl, libstdc++, gcc-patches
Geez, working on too many different branches. This is *not* a pph patch.
On Sat, Apr 16, 2011 at 16:30, Diego Novillo <dnovillo@google.com> wrote:
> I am committing this patch for David Li on google/main.
>
> The patch adds explicit initialization to the fields of
> _Hashtable_iterator in its default constructor. David, could you
> describe why this change was needed? Will you be submitting for
> trunk?
>
> Tested on x86_64. Committed to google/main.
>
>
> Diego.
>
> 2011-04-15 Xinliang David Li <davidxl@google.com>
>
> Google ref 43787.
>
> * include/backward/hashtable.h
> (_Hashtable_iterator::_Hashtable_iterator): Initialize _M_cur and
> _M_ht in default constructor.
>
> diff --git a/libstdc++-v3/include/backward/hashtable.h b/libstdc++-v3/include/backward/hashtable.h
> index 0bcaec4..c3eefcc 100644
> --- a/libstdc++-v3/include/backward/hashtable.h
> +++ b/libstdc++-v3/include/backward/hashtable.h
> @@ -126,7 +126,8 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION
> _Hashtable_iterator(_Node* __n, _Hashtable* __tab)
> : _M_cur(__n), _M_ht(__tab) { }
>
> - _Hashtable_iterator() { }
> + _Hashtable_iterator()
> + : _M_cur(0), _M_ht(0) { }
>
> reference
> operator*() const
>
> --
> This patch is available for review at http://codereview.appspot.com/4430051
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-16 20:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-16 22:42 [pph] Initialize fields in default ctor for _Hashtable_iterator (issue4430051) Diego Novillo
2011-04-16 22:46 ` [google] " Diego Novillo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).