From: Basile Starynkevitch <basile@starynkevitch.net>
To: "Nicola Pero" <nicola.pero@meta-innovation.com>
Cc: "gcc-patches@gnu.org" <gcc-patches@gnu.org>
Subject: Re: Fix gengtype-state string hashtable
Date: Sun, 17 Apr 2011 09:48:00 -0000 [thread overview]
Message-ID: <20110417090818.05a31663.basile@starynkevitch.net> (raw)
In-Reply-To: <1303001733.34455839@www2.webmail.us>
On Sun, 17 Apr 2011 02:55:33 +0200 (CEST)
"Nicola Pero" <nicola.pero@meta-innovation.com> wrote:
> While reading GCC code, I noticed that in gengtype-state.c
> the equality function in a string hashtable is set to strcmp.
>
> But that returns 0 (ie, false for hashtable.c) when the strings
> are equal! I can't see how that hashtable would ever work. Do
> we have any tests for gengtype-state ? Am I missing something ? :-)
>
> Else, Ok to commit the following patch ?
I am not authorized to Ok it, but I hope it will be oked.
Thanks for finding that bug.
Cheers
--
Basile STARYNKEVITCH http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mine, sont seulement les miennes} ***
next prev parent reply other threads:[~2011-04-17 7:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-17 7:27 Nicola Pero
2011-04-17 9:48 ` Basile Starynkevitch [this message]
2011-04-19 7:07 ` Laurynas Biveinis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110417090818.05a31663.basile@starynkevitch.net \
--to=basile@starynkevitch.net \
--cc=gcc-patches@gnu.org \
--cc=nicola.pero@meta-innovation.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).