public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@ucw.cz>
To: Richard Guenther <richard.guenther@gmail.com>
Cc: Jan Hubicka <hubicka@ucw.cz>,
	Dominique Dhumieres <dominiq@lps.ens.fr>,
	gcc-patches@gcc.gnu.org, richard.guenthe@gmail.com,
	Michael Matz <matz@suse.de>
Subject: Re: More of ipa-inline housekeeping
Date: Sun, 17 Apr 2011 13:22:00 -0000	[thread overview]
Message-ID: <20110417123602.GA23956@kam.mff.cuni.cz> (raw)
In-Reply-To: <BANLkTimN+vbXLe0uH6shsDZ=3-SkrbJbtA@mail.gmail.com>

> >
> > I never really tuned the stack frame growth heuristics since it did not cause any problems
> > in the benchmarks. On fortran this is quite different because of the large i/o blocks
> > hitting it very commonly, so I will look into making it more permissive.  We definitely
> > can just bump up the limits and/or we can also teach it that if call dominates the return
> > there is not really much to save of stack usage by preventing inlining since both stack
> > frames will wind up on the stack anyway.
> 
> I think Micha has a fix for the I/O block issue.

Good, how he fixed this?
In any case I sort of like the idea of tracking whether function call happens always and
bypassing limits in that case.  There seems to be cases of functions called once that
are not inlined for this reason and there is no danger for doing so.  I saw that in combine.c
dump as well as in the ac polyhedron benchmark I just looked that.  In case of combine.c it is
definitely becuase of standard non-scalar local vars.

Honza
> 
> Richard.
> 
> > This means adding new bit whether call edge dominate exit and using this info. Also simple
> > noreturn IPA discovery can be based on this and I recently noticed it might be important
> > for Mozilla. So I will give it a try soonish.
> >
> > I will also look into the estimate_size ICE reported today.
> >
> > Honza
> >

  reply	other threads:[~2011-04-17 12:36 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-15 15:22 Dominique Dhumieres
2011-04-17 10:23 ` Jan Hubicka
2011-04-17 12:08   ` Richard Guenther
2011-04-17 13:22     ` Jan Hubicka [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-04-17 10:35 Dominique Dhumieres
2011-04-15 15:27 Dominique Dhumieres
2011-04-13 22:20 Jan Hubicka
2011-04-14  8:59 ` Richard Guenther
2011-04-15 10:32   ` Jan Hubicka
2011-04-15 10:38     ` Richard Guenther
2011-04-15 11:40       ` Jan Hubicka
2011-04-17  1:18 ` H.J. Lu
2011-04-17  1:27   ` H.J. Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110417123602.GA23956@kam.mff.cuni.cz \
    --to=hubicka@ucw.cz \
    --cc=dominiq@lps.ens.fr \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=matz@suse.de \
    --cc=richard.guenthe@gmail.com \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).