public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@ucw.cz>
To: Diego Novillo <dnovillo@google.com>
Cc: Xinliang David Li <davidxl@google.com>,
	GCC Patches <gcc-patches@gcc.gnu.org>, Jan Hubicka <jh@suse.cz>
Subject: Re: FDO usability trivial patch to fix div by zero error with	insane profile
Date: Sun, 17 Apr 2011 16:35:00 -0000	[thread overview]
Message-ID: <20110417151850.GD911@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <BANLkTikpwRV7Xta3gRY4cmNz1NP6bNy4PA@mail.gmail.com>

> On Fri, Apr 15, 2011 at 15:20, Xinliang David Li <davidxl@google.com> wrote:
> > This is a trivial patch to deal with bad profile data (from
> > multi-threaded programs) that leads to divide by zero error.
> >
> > Ok for trunk?
> >
> > Thanks,
> >
> > David
> >
> >
> >
> > 2011-04-15  Xinliang David Li  <davidxl@google.com>
> >
> >        * ipa-inline.c (cgraph_decide_recursive_inlining): Fix
> >        div by zero error with insane profile.
> 
> Looks fine to me, but you really want Honza to review this.  Any
> chance we can get a test case for this?

Yes, this is OK for release branches.
On mainline I already fixed it with the current inliner reorg.  The weird think
is that the problem reproduce with sqlite build when profile is not present and
thus all counters should be zero.  Since the division is already guarded by
max_count being 0, someone must set non-zero count of some cgrpah edge that is
wrong.  I will need to investigate this...

Thanks,
Honza
> 
> 
> Diego.

      parent reply	other threads:[~2011-04-17 15:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-15 20:21 Xinliang David Li
2011-04-15 20:21 ` Diego Novillo
2011-04-15 20:33   ` Xinliang David Li
2011-04-15 21:20     ` Diego Novillo
2011-04-17 16:35   ` Jan Hubicka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110417151850.GD911@atrey.karlin.mff.cuni.cz \
    --to=hubicka@ucw.cz \
    --cc=davidxl@google.com \
    --cc=dnovillo@google.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jh@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).