* [PATCH] Fix PR48650
@ 2011-04-18 11:25 Richard Guenther
2011-04-18 13:57 ` Nathan Froyd
0 siblings, 1 reply; 2+ messages in thread
From: Richard Guenther @ 2011-04-18 11:25 UTC (permalink / raw)
To: gcc-patches; +Cc: froydnj
STRING_CST is now derived from tree_typed but we still clear a
tree_common sized chunk. Nathan, maybe grep for other sizeof()s
around the tree?
Installed as obvious.
Richard.
2011-04-18 Richard Guenther <rguenther@suse.de>
PR middle-end/48650
* tree.c (build_string): STRING_CST is now derived from tree_typed.
Index: gcc/tree.c
===================================================================
*** gcc/tree.c (revision 172640)
--- gcc/tree.c (working copy)
*************** build_string (int len, const char *str)
*** 1521,1527 ****
s = ggc_alloc_tree_node (length);
! memset (s, 0, sizeof (struct tree_common));
TREE_SET_CODE (s, STRING_CST);
TREE_CONSTANT (s) = 1;
TREE_STRING_LENGTH (s) = len;
--- 1521,1527 ----
s = ggc_alloc_tree_node (length);
! memset (s, 0, sizeof (struct tree_typed));
TREE_SET_CODE (s, STRING_CST);
TREE_CONSTANT (s) = 1;
TREE_STRING_LENGTH (s) = len;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix PR48650
2011-04-18 11:25 [PATCH] Fix PR48650 Richard Guenther
@ 2011-04-18 13:57 ` Nathan Froyd
0 siblings, 0 replies; 2+ messages in thread
From: Nathan Froyd @ 2011-04-18 13:57 UTC (permalink / raw)
To: Richard Guenther; +Cc: gcc-patches
On Mon, Apr 18, 2011 at 12:46:52PM +0200, Richard Guenther wrote:
> STRING_CST is now derived from tree_typed but we still clear a
> tree_common sized chunk. Nathan, maybe grep for other sizeof()s
> around the tree?
Ouch, thanks for fixing. I grepped for 'struct tree_common' and turned
up a few things that might trigger when tree_exp gets smaller, but not
much else. I'll check those before committing the tree_exp slimming and
post patches if necessary.
-Nathan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-18 13:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-18 11:25 [PATCH] Fix PR48650 Richard Guenther
2011-04-18 13:57 ` Nathan Froyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).