From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-289798-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 4026 invoked by alias); 18 Apr 2011 15:33:09 -0000
Received: (qmail 4016 invoked by uid 22791); 18 Apr 2011 15:33:08 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0	tests=AWL,BAYES_00,TW_TM,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from nikam.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 18 Apr 2011 15:32:53 +0000
Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202)	id 3AFA99AC80D; Mon, 18 Apr 2011 17:32:52 +0200 (CEST)
Date: Mon, 18 Apr 2011 15:40:00 -0000
From: Jan Hubicka <hubicka@ucw.cz>
To: Richard Guenther <rguenther@suse.de>
Cc: Jan Hubicka <hubicka@ucw.cz>, gcc-patches@gcc.gnu.org, mjambor@suse.cz
Subject: Re: Remove vtable_method field in cgraph_node
Message-ID: <20110418153252.GC23956@kam.mff.cuni.cz>
References: <20110417163459.GH5273@kam.mff.cuni.cz> <alpine.LNX.2.00.1104172143120.810@zhemvz.fhfr.qr> <20110417230342.GB23956@kam.mff.cuni.cz> <alpine.LNX.2.00.1104181054500.810@zhemvz.fhfr.qr>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.LNX.2.00.1104181054500.810@zhemvz.fhfr.qr>
User-Agent: Mutt/1.5.18 (2008-05-17)
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2011-04/txt/msg01402.txt.bz2

> Ah, no.  We _did_ that in CCP but now we only adjust the OBJ_TYPE_REF
> expr in CCP and defer to fold_stmt to eventually "devirtualize" it.
> See PR45878.  Then rev.165435 was necessary, as we dropped OBJ_TYPE_REF
> for the non-devirtualized call as well.  As both cases were because

Hmm, sounds slipperly.
In any case OBJ_TYPE_REF of constant argument should be banned, or
we would need to extend gimple_call_fndecl to return contained fndecl.
Devirtualization without enabling an inlining is essentially useless transform
and it is precisely what we do now on this testcase...
> of type conversion issues this should be fixed with separating the
> call function type as we do now.
> 
> I'll look into handling copyprop and FRE similarly.

Thanks,  I would not even mind having some automatic check that the constant
OBJ_TYPE_REFs don't leak at cgraph edge construction time...
Honza
> 
> Richard.