From: Nathan Froyd <froydnj@codesourcery.com>
To: gcc-patches@gcc.gnu.org, David Edelsohn <dje.gcc@gmail.com>,
dalej@apple.com, mikestump@comcast.net
Subject: Re: Allow more PowerPC sibling calls
Date: Mon, 18 Apr 2011 17:37:00 -0000 [thread overview]
Message-ID: <20110418172917.GA23480@codesourcery.com> (raw)
In-Reply-To: <20110409025146.GF19002@bubble.grove.modra.org>
On Sat, Apr 09, 2011 at 12:21:46PM +0930, Alan Modra wrote:
> a) Allow sibling calls via function pointer. At the time
> rs6000_function_ok_for_sibcall was written, I don't think access to
> arg types of function pointer calls was available in the target
> hook/macro.
>
> + /* Functions with vector parameters are required to have a
> + prototype, so the argument type info must be available
> + here. */
> + for (type = TYPE_ARG_TYPES (fntype);
> + type;
> + type = TREE_CHAIN (type))
> + if (TREE_CODE (TREE_VALUE (type)) == VECTOR_TYPE
> + && (ALTIVEC_VECTOR_MODE (TYPE_MODE (TREE_VALUE (type)))
> + || VSX_VECTOR_MODE (TYPE_MODE (TREE_VALUE (type)))))
> + nvreg++;
> +
> + for (type = TYPE_ARG_TYPES (TREE_TYPE (current_function_decl));
> + type;
> + type = TREE_CHAIN (type))
> + if (TREE_CODE (TREE_VALUE (type)) == VECTOR_TYPE
> + && (ALTIVEC_VECTOR_MODE (TYPE_MODE (TREE_VALUE (type)))
> + || VSX_VECTOR_MODE (TYPE_MODE (TREE_VALUE (type)))))
> + nvreg--;
Could I request that you use FOREACH_FUNCTION_ARGS in these two cases?
The conversion is trivial, and avoiding more exposed TYPE_ARG_TYPES
calls is a good thing.
Thanks,
-Nathan
next prev parent reply other threads:[~2011-04-18 17:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-09 2:52 Alan Modra
2011-04-18 17:34 ` David Edelsohn
2011-04-18 21:25 ` Mike Stump
2011-04-18 17:37 ` Nathan Froyd [this message]
2011-04-22 5:00 ` Alan Modra
2011-04-22 6:13 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110418172917.GA23480@codesourcery.com \
--to=froydnj@codesourcery.com \
--cc=dalej@apple.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mikestump@comcast.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).