From: Jan Hubicka <hubicka@ucw.cz>
To: gcc-patches@gcc.gnu.org, mark@codesourcery.com
Subject: [c++] Remove redundant inline check
Date: Mon, 18 Apr 2011 18:52:00 -0000 [thread overview]
Message-ID: <20110418184702.GN5273@kam.mff.cuni.cz> (raw)
Hi,
the test whether function contains computed goto is re-done by tree-inline (and re-done
after optimization, so it is bit more sensitive). There is also nothing language specific
in this.
Bootstrapped/regtested x86_64-linux, OK?
* cp/semantics.c (finish_goto_stmt): Do set UNINLINABLE flag on computed
gotos.
Index: cp/semantics.c
===================================================================
--- cp/semantics.c (revision 172657)
+++ cp/semantics.c (working copy)
@@ -569,11 +569,6 @@ finish_goto_stmt (tree destination)
if (error_operand_p (destination))
return NULL_TREE;
}
- /* We don't inline calls to functions with computed gotos.
- Those functions are typically up to some funny business,
- and may be depending on the labels being at particular
- addresses, or some such. */
- DECL_UNINLINABLE (current_function_decl) = 1;
}
check_goto (destination);
next reply other threads:[~2011-04-18 18:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-18 18:52 Jan Hubicka [this message]
2011-04-18 19:52 ` Mark Mitchell
2011-04-18 21:28 ` Richard Guenther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110418184702.GN5273@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=mark@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).