From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22176 invoked by alias); 22 Apr 2011 18:55:57 -0000 Received: (qmail 22166 invoked by uid 22791); 22 Apr 2011 18:55:56 -0000 X-SWARE-Spam-Status: No, hits=-6.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 Apr 2011 18:55:42 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p3MItggV028674 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 22 Apr 2011 14:55:42 -0400 Received: from tyan-ft48-01.lab.bos.redhat.com (tyan-ft48-01.lab.bos.redhat.com [10.16.42.4]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p3MItf0h031054 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 22 Apr 2011 14:55:41 -0400 Received: from tyan-ft48-01.lab.bos.redhat.com (localhost.localdomain [127.0.0.1]) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4) with ESMTP id p3MItewu010341; Fri, 22 Apr 2011 20:55:40 +0200 Received: (from jakub@localhost) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4/Submit) id p3MIteIl010340; Fri, 22 Apr 2011 20:55:40 +0200 Date: Fri, 22 Apr 2011 19:26:00 -0000 From: Jakub Jelinek To: Richard Guenther Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix associate_plusminus A + ~A optimization (PR tree-optimization/48717) Message-ID: <20110422185540.GX17079@tyan-ft48-01.lab.bos.redhat.com> Reply-To: Jakub Jelinek References: <20110422134120.GV17079@tyan-ft48-01.lab.bos.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg01889.txt.bz2 On Fri, Apr 22, 2011 at 04:50:26PM +0200, Richard Guenther wrote: > build_int_cst looks seriously broken, I think we want to make it > an alias of build_int_cst_type, or rather call that from > build_int_cst. The comment above build_int_cst_type talks about it: "We cannot however make this a default behavior of build_int_cst without more intrusive changes, since there are parts of gcc that rely on the extra precision of the integer constants." Jakub