From: Jakub Jelinek <jakub@redhat.com>
To: Richard Guenther <rguenther@suse.de>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Properly build integer constants
Date: Fri, 22 Apr 2011 20:08:00 -0000 [thread overview]
Message-ID: <20110422194748.GY17079@tyan-ft48-01.lab.bos.redhat.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1104222126220.810@zhemvz.fhfr.qr>
On Fri, Apr 22, 2011 at 09:27:50PM +0200, Richard Guenther wrote:
> There is a scary comment before build_int_cst_type why build_int_cst
> can't be sane. Fortunately it is not true. If it were there would
> be other code to be fixed.
>
> Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk.
http://gcc.gnu.org/ml/gcc-patches/2004-08/msg02297.html
suggests that at least back then the old semantics of build_int_cst
was needed in round_up and build_prim_array_type.
> 2011-04-22 Richard Guenther <rguenther@suse.de>
>
> * tree.c (build_int_cst): Properly create canonicalized integer
> constants.
> (build_int_cst_type): Remove scary comments.
Jakub
next prev parent reply other threads:[~2011-04-22 19:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-22 19:48 Richard Guenther
2011-04-22 20:08 ` Jakub Jelinek [this message]
2011-04-24 21:17 ` H.J. Lu
2011-05-03 3:08 ` H.J. Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110422194748.GY17079@tyan-ft48-01.lab.bos.redhat.com \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).