public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@ucw.cz>
To: Xinliang David Li <davidxl@google.com>
Cc: Jan Hubicka <hubicka@ucw.cz>,
	GCC Patches <gcc-patches@gcc.gnu.org>,
	Diego Novillo <dnovillo@google.com>
Subject: Re: FDO usability patch -- cfg and lineno checksum
Date: Fri, 22 Apr 2011 20:11:00 -0000	[thread overview]
Message-ID: <20110422194817.GS911@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <BANLkTikaCW-5AS32M4DEEf+YQeYByaAgQA@mail.gmail.com>

> Please review the new patch which only implements cfg checksum.
> 
> The auto version generation was introduced in 2002 before FDO support
> was added (so the old way never existed), so it might be better to
> make the change independent of this one.

FDO support was there well before 2002, just with funny combination of flags.
(-fprofile-arcs and -fbranch-probabilities)
2002 was about the time of GCOV format rewrite, but yes, lets change it independently
I will look into the patch ASAP.

Honza

  reply	other threads:[~2011-04-22 19:48 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-13 22:26 Xinliang David Li
2011-04-13 22:34 ` Xinliang David Li
     [not found] ` <BANLkTinVavyXCqy88TpqLzmexp2LQ1Pwqw@mail.gmail.com>
2011-04-15 16:54   ` Xinliang David Li
2011-04-17 17:15 ` Jan Hubicka
2011-04-17 19:22   ` Xinliang David Li
2011-04-19 20:37   ` Xinliang David Li
2011-04-19 22:36     ` Jan Hubicka
2011-04-21  8:30       ` Xinliang David Li
2011-04-21 22:21         ` Jan Hubicka
2011-04-21 22:42           ` Xinliang David Li
2011-04-22 19:35             ` Xinliang David Li
2011-04-22 20:11               ` Jan Hubicka [this message]
2011-04-25 17:05                 ` Xinliang David Li
2011-04-27 16:22                   ` Xinliang David Li
2011-04-27 16:27               ` Jan Hubicka
2011-04-27 17:45                 ` Xinliang David Li
2011-04-27 17:54                   ` Jan Hubicka
2011-04-27 17:57                     ` Xinliang David Li
2011-04-21 18:23     ` Diego Novillo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110422194817.GS911@atrey.karlin.mff.cuni.cz \
    --to=hubicka@ucw.cz \
    --cc=davidxl@google.com \
    --cc=dnovillo@google.com \
    --cc=gcc-patches@gcc.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).