From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8062 invoked by alias); 26 Apr 2011 21:45:00 -0000 Received: (qmail 8050 invoked by uid 22791); 26 Apr 2011 21:44:59 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from mailout-de.gmx.net (HELO mailout-de.gmx.net) (213.165.64.22) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Tue, 26 Apr 2011 21:44:38 +0000 Received: (qmail invoked by alias); 26 Apr 2011 21:44:37 -0000 Received: from xdsl-89-0-147-11.netcologne.de (EHLO localhost.localdomain) [89.0.147.11] by mail.gmx.net (mp006) with SMTP; 26 Apr 2011 23:44:37 +0200 Received: from ralf by localhost.localdomain with local (Exim 4.72) (envelope-from ) id 1QEq3f-0004O2-GV; Tue, 26 Apr 2011 23:44:35 +0200 Date: Tue, 26 Apr 2011 22:27:00 -0000 From: Ralf Wildenhues To: Rainer Orth Cc: Richard Guenther , Michael Matz , gcc-patches@gcc.gnu.org, Richard Guenther , Paolo Bonzini Subject: Re: [build, lto] Only accept -fuse-linker-plugin if linker supports -plugin (PR lto/46944) Message-ID: <20110426214434.GA16862@gmx.de> Mail-Followup-To: Ralf Wildenhues , Rainer Orth , Richard Guenther , Michael Matz , gcc-patches@gcc.gnu.org, Richard Guenther , Paolo Bonzini References: <20110418181248.GB26439@gmx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2010-08-04) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg02071.txt.bz2 Hello Rainer, * Rainer Orth wrote on Tue, Apr 26, 2011 at 05:28:19PM CEST: > it's been a week since I answered your questions on this patch. Could > you please have a look? Sorry for the delay. I'm practically AFK until the weekend or maybe next weekend, whenever I have connectivity again after relocating; if another build maintainer could take a look that would be nice, otherwise I will get to it ASAP. Thanks, Ralf > >>> I haven't found if there are provisions for in-tree gold, though, and > >>> still cannot test that. > >> > >> I'm not quite sure I understand this statement. I built a combined tree > >> with gold enabled a while ago (must've been several months now). > >> I might be misunderstanding this. > > > > I suppose I've been unclear: I'm specificially referring to the current > > code for setting gcc_cv_lto_plugin: in the in-tree case, there's nothing > > that deals with in-tree gold. > > > >>> if test $in_tree_ld = yes -a x"$ORIGINAL_PLUGIN_LD_FOR_TARGET" = x"$gcc_cv_ld"; then > >>> - if test "$gcc_cv_gld_major_version" -eq 2 -a "$gcc_cv_gld_minor_version" -ge 21 -o "$gcc_cv_gld_major_version" -gt 2; then > >>> - gcc_cv_lto_plugin=2 > >>> - elif test "$ld_is_gold" = yes -a "$gcc_cv_gld_major_version" -eq 2 -a "$gcc_cv_gld_minor_version" -eq 20; then > >>> - gcc_cv_lto_plugin=1 > >>> - > >>> + ld_ver="GNU ld" > >>> + # FIXME: ld_is_gold? > >> > >> What about this FIXME? Did you test gold? Is it not relevant here? > >> Can the FIXME go? > > > > I cannot test gold since it doesn't yet work on Solaris: cf. binutils PR > > gold/12525. We made some progress on that front, but the PR is > > currently stalled and I had other things on my plate that prevented me > > from pushing it. As I said, the current code (before my patch) doesn't > > handle in-tree gold, so I don't feel obliged to change that, especially > > since I'm in no good position to test. > > > >>> + ld_vers_major=`expr "$ld_vers" : '\([0-9]*\)'` > >>> + ld_vers_minor=`expr "$ld_vers" : '[0-9]*\.\([0-9]*\)'` > >> > >> Can you try the expr statements quickly on Tru64? If not, I can do it > >> for you ('info Autoconf --index expr' is long and tells of many woes). > > > > I just tried with /bin/expr and ld_vers set to 2.20.1. OTOH, this isn't > > relevant for two reasons: this code is identical to the one determining > > ld_vers_major/ld_vers_minor further up in gcc/configure.ac, and GNU ld > > (as well as GNU as) aren't currently supported on Tru64 UNIX and I > > seriously doubt that will change over the remaining livetime of the > > platform. > > > >> Thanks, and sorry for the delay, > > > > No worries. I'd just like to get this series of patches out of my queue > > (and eventually backported to the 4.6 branch if all issues are sorted > > out). Maybe one of the build maintainers finds some time to handle the > > current mess that are the linker tests in gcc/configure.ac, compared to > > what we do for the assembler.