From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1367 invoked by alias); 29 Apr 2011 21:29:05 -0000 Received: (qmail 1356 invoked by uid 22791); 29 Apr 2011 21:29:04 -0000 X-SWARE-Spam-Status: No, hits=-2.1 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 29 Apr 2011 21:28:50 +0000 Received: from kpbe11.cbf.corp.google.com (kpbe11.cbf.corp.google.com [172.25.105.75]) by smtp-out.google.com with ESMTP id p3TLSlWL002463; Fri, 29 Apr 2011 14:28:48 -0700 Received: from jade.mtv.corp.google.com (jade.mtv.corp.google.com [172.18.116.94]) by kpbe11.cbf.corp.google.com with ESMTP id p3TLSkGl012664; Fri, 29 Apr 2011 14:28:46 -0700 Received: by jade.mtv.corp.google.com (Postfix, from userid 21482) id 1A14F2225D2; Fri, 29 Apr 2011 14:28:46 -0700 (PDT) To: reply@codereview.appspotmail.com, dnovillo@google.com, gcc-patches@gcc.gnu.org Subject: [pph] DECL_INITIAL instead of DECL_ARG_TYPE (issue4442102) Message-Id: <20110429212846.1A14F2225D2@jade.mtv.corp.google.com> Date: Fri, 29 Apr 2011 21:46:00 -0000 From: crowl@google.com (Lawrence Crowl) X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg02377.txt.bz2 In the pph file, save and restore DECL_INITIAL instead of just PARM_DECL DECL_ARG_TYPE. Index: gcc/cp/ChangeLog.pph 2011-04-29 Lawrence Crowl * pph-streamer-out.c (pph_stream_write_tree): Write DECL_INITIAL instead of PARM_DECL DECL_ARG_TYPE. * pph-streamer-in.c (pph_stream_read_tree): Read DECL_INITIAL instead of PARM_DECL DECL_ARG_TYPE. Index: gcc/cp/pph-streamer-in.c =================================================================== --- gcc/cp/pph-streamer-in.c (revision 173189) +++ gcc/cp/pph-streamer-in.c (working copy) @@ -783,6 +783,8 @@ pph_stream_read_tree (struct lto_input_b if (DECL_P (expr)) { + DECL_INITIAL (expr) = pph_input_tree (stream); + if (TREE_CODE (expr) == FUNCTION_DECL || TREE_CODE (expr) == NAMESPACE_DECL || TREE_CODE (expr) == PARM_DECL @@ -791,8 +793,6 @@ pph_stream_read_tree (struct lto_input_b pph_stream_read_lang_specific (stream, expr); if (TREE_CODE (expr) == FUNCTION_DECL) DECL_SAVED_TREE (expr) = pph_input_tree (stream); - else if (TREE_CODE (expr) == PARM_DECL) - DECL_ARG_TYPE (expr) = pph_input_tree (stream); } if (TREE_CODE (expr) == TYPE_DECL) Index: gcc/cp/pph-streamer-out.c =================================================================== --- gcc/cp/pph-streamer-out.c (revision 173189) +++ gcc/cp/pph-streamer-out.c (working copy) @@ -787,6 +787,8 @@ pph_stream_write_tree (struct output_blo if (DECL_P (expr)) { + pph_output_tree_or_ref_1 (stream, DECL_INITIAL (expr), ref_p, 3); + if (TREE_CODE (expr) == FUNCTION_DECL || TREE_CODE (expr) == NAMESPACE_DECL || TREE_CODE (expr) == PARM_DECL @@ -796,8 +798,6 @@ pph_stream_write_tree (struct output_blo if (TREE_CODE (expr) == FUNCTION_DECL) pph_output_tree_or_ref_1 (stream, DECL_SAVED_TREE (expr), ref_p, 3); - else if (TREE_CODE (expr) == PARM_DECL) - pph_output_tree_or_ref_1 (stream, DECL_ARG_TYPE (expr), ref_p, 3); } if (TREE_CODE (expr) == TYPE_DECL) -- This patch is available for review at http://codereview.appspot.com/4442102