From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4558 invoked by alias); 4 May 2011 10:07:08 -0000 Received: (qmail 4424 invoked by uid 22791); 4 May 2011 10:07:06 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_EQ,TW_OV,TW_ZJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 04 May 2011 10:06:50 +0000 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p44A6ncx010170 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 4 May 2011 06:06:49 -0400 Received: from tyan-ft48-01.lab.bos.redhat.com (tyan-ft48-01.lab.bos.redhat.com [10.16.42.4]) by int-mx12.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p44A6mSZ016891 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 4 May 2011 06:06:49 -0400 Received: from tyan-ft48-01.lab.bos.redhat.com (localhost.localdomain [127.0.0.1]) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4) with ESMTP id p44A6m2r032759; Wed, 4 May 2011 12:06:48 +0200 Received: (from jakub@localhost) by tyan-ft48-01.lab.bos.redhat.com (8.14.4/8.14.4/Submit) id p44A6m0p032757; Wed, 4 May 2011 12:06:48 +0200 Date: Wed, 04 May 2011 10:08:00 -0000 From: Jakub Jelinek To: Uros Bizjak Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH, i386]: Fix target/48860: bootstrap fails on x86_64-apple-darwin10; broken assembler edition. Message-ID: <20110504100648.GD17079@tyan-ft48-01.lab.bos.redhat.com> Reply-To: Jakub Jelinek References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg00271.txt.bz2 On Wed, May 04, 2011 at 12:02:17PM +0200, Uros Bizjak wrote: > Tested on x86_64-pc-linux-gnu, committed to mainline SVN. I will audit > movq usage in other release branches as well. s/reqire/require/g > --- config/i386/i386.md (revision 173353) > +++ config/i386/i386.md (working copy) > @@ -2001,11 +2001,13 @@ > case TYPE_SSEMOV: > if (get_attr_mode (insn) == MODE_TI) > return "%vmovdqa\t{%1, %0|%0, %1}"; > + /* Handle broken assemblers that reqire movd instead of movq. */ > + if (GENERAL_REG_P (operands[0]) || GENERAL_REG_P (operands[1])) > + return "%vmovd\t{%1, %0|%0, %1}"; > return "%vmovq\t{%1, %0|%0, %1}"; > > case TYPE_MMXMOV: > - /* Moves from and into integer register is done using movd > - opcode with REX prefix. */ > + /* Handle broken assemblers that reqire movd instead of movq. */ > if (GENERAL_REG_P (operands[0]) || GENERAL_REG_P (operands[1])) > return "movd\t{%1, %0|%0, %1}"; > return "movq\t{%1, %0|%0, %1}"; > @@ -3018,7 +3020,8 @@ > > case 11: > case 12: > - return "%vmovd\t{%1, %0|%0, %1}"; > + /* Handle broken assemblers that reqire movd instead of movq. */ > + return "%vmovd\t{%1, %0|%0, %1}"; > > default: > gcc_unreachable(); Jakub