From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32249 invoked by alias); 4 May 2011 10:00:37 -0000 Received: (qmail 32241 invoked by uid 22791); 4 May 2011 10:00:36 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 04 May 2011 10:00:23 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id D827ECB02E0; Wed, 4 May 2011 12:00:21 +0200 (CEST) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id qHTP0vD4gMBD; Wed, 4 May 2011 12:00:18 +0200 (CEST) Received: from new-host.home (ADijon-552-1-27-110.w92-138.abo.wanadoo.fr [92.138.162.110]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id 8895FCB0299; Wed, 4 May 2011 12:00:18 +0200 (CEST) From: Eric Botcazou To: Richard Guenther Subject: Re: [google]: initialize language field for clone function struct Date: Wed, 04 May 2011 10:02:00 -0000 User-Agent: KMail/1.9.9 Cc: gcc-patches@gcc.gnu.org, Xinliang David Li , Jan Hubicka References: In-Reply-To: MIME-Version: 1.0 Content-Disposition: inline Message-Id: <201105041200.29307.ebotcazou@adacore.com> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg00269.txt.bz2 > Umm, I think most of them (if not all) are just bogus. If a FE doesn't > want to fold some stuff when at global scope it should not call fold. That isn't so easy because fold is invoked on sizes of types by stor-layout.c and these sizes can be variable (at least in Ada). So I think that the calls to the hook are still needed. But: 1) The -1 thing should go and the hook return boolean. The prerequisite is to tidy up variable_size, 2) I think that the GIMPLE hook can return 0 unconditionally. > But I'm not sure that is actually what it tries to do ... and the existing > checks are far from consistently spread out in fold-const.c ... It prevents save_expr from being called at global level, since you cannot create SAVE_EXPRs outside functions. Likewise in variable_size. -- Eric Botcazou