From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14670 invoked by alias); 4 May 2011 16:05:58 -0000 Received: (qmail 14656 invoked by uid 22791); 4 May 2011 16:05:56 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00 X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 04 May 2011 16:05:42 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id D2DB0CB0214; Wed, 4 May 2011 18:05:41 +0200 (CEST) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LHUNu1C-5wSr; Wed, 4 May 2011 18:05:38 +0200 (CEST) Received: from new-host.home (ADijon-552-1-27-110.w92-138.abo.wanadoo.fr [92.138.162.110]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id B68D0CB0255; Wed, 4 May 2011 18:05:38 +0200 (CEST) From: Eric Botcazou To: Richard Guenther Subject: Re: [PATCH] Cleanup expand_shift Date: Wed, 04 May 2011 16:09:00 -0000 User-Agent: KMail/1.9.9 Cc: gcc-patches@gcc.gnu.org References: <201105041732.49116.ebotcazou@adacore.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <201105041805.43662.ebotcazou@adacore.com> Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg00317.txt.bz2 > I think I did it that way because the old code tried to re-construct > the type of the original amount. I can surely simply use op1 here > if that is preferred. Right, but it used the value of OP1 so I think the new code should as well. > Btw, do you happen to know any target that would excercise this code > choosing from x86, ppc, s390 and ia64? All have rotate instructions so this seems to be a wash. -- Eric Botcazou