* [PATCH} fix --enable-build-with-cxx
@ 2011-05-05 11:55 Jack Howarth
2011-05-05 12:08 ` Eric Botcazou
0 siblings, 1 reply; 7+ messages in thread
From: Jack Howarth @ 2011-05-05 11:55 UTC (permalink / raw)
To: gcc-patches
Currently the bootstrap with --enable-build-with-cxx is broken due to compiler errors of the form
"error: converting 'false' to pointer type 'varpool_node*' [-Werror=conversion-null]". The attached
patch changes these instances of false to NULL and restores the --enable-build-with-cxx bootstrap.
Tested on x86_64-apple-darwin10. Okay for gcc trunk?
Jack
2011-05-05 Jack Howarth <howarth@bromo.med.uc.edu>
* gcc/tree-inline.c (maybe_inline_call_in_expr): Use NULL.
* gcc/varpool.c (varpool_extra_name_alias): Likewise.
Index: gcc/tree-inline.c
===================================================================
--- gcc/tree-inline.c (revision 173423)
+++ gcc/tree-inline.c (working copy)
@@ -5238,7 +5238,7 @@ maybe_inline_call_in_expr (tree exp)
id.transform_call_graph_edges = CB_CGE_DUPLICATE;
id.transform_new_cfg = false;
id.transform_return_to_modify = true;
- id.transform_lang_insert_block = false;
+ id.transform_lang_insert_block = NULL;
/* Make sure not to unshare trees behind the front-end's back
since front-end specific mechanisms may rely on sharing. */
Index: gcc/varpool.c
===================================================================
--- gcc/varpool.c (revision 173423)
+++ gcc/varpool.c (working copy)
@@ -676,7 +676,7 @@ varpool_extra_name_alias (tree alias, tr
#ifndef ASM_OUTPUT_DEF
/* If aliases aren't supported by the assembler, fail. */
- return false;
+ return NULL;
#endif
gcc_assert (TREE_CODE (decl) == VAR_DECL);
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH} fix --enable-build-with-cxx
2011-05-05 11:55 [PATCH} fix --enable-build-with-cxx Jack Howarth
@ 2011-05-05 12:08 ` Eric Botcazou
2011-05-05 12:56 ` Jack Howarth
0 siblings, 1 reply; 7+ messages in thread
From: Eric Botcazou @ 2011-05-05 12:08 UTC (permalink / raw)
To: Jack Howarth; +Cc: gcc-patches
> Currently the bootstrap with --enable-build-with-cxx is broken due to
> compiler errors of the form "error: converting 'false' to pointer type
> 'varpool_node*' [-Werror=conversion-null]". The attached patch changes
> these instances of false to NULL and restores the --enable-build-with-cxx
> bootstrap. Tested on x86_64-apple-darwin10. Okay for gcc trunk?
http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00045.html has the first hunk so
you should credit Dmitry.
--
Eric Botcazou
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH} fix --enable-build-with-cxx
2011-05-05 12:08 ` Eric Botcazou
@ 2011-05-05 12:56 ` Jack Howarth
2011-05-05 12:58 ` Gabriel Dos Reis
2011-05-05 13:38 ` Eric Botcazou
0 siblings, 2 replies; 7+ messages in thread
From: Jack Howarth @ 2011-05-05 12:56 UTC (permalink / raw)
To: Eric Botcazou; +Cc: gcc-patches
On Thu, May 05, 2011 at 02:02:19PM +0200, Eric Botcazou wrote:
> > Currently the bootstrap with --enable-build-with-cxx is broken due to
> > compiler errors of the form "error: converting 'false' to pointer type
> > 'varpool_node*' [-Werror=conversion-null]". The attached patch changes
> > these instances of false to NULL and restores the --enable-build-with-cxx
> > bootstrap. Tested on x86_64-apple-darwin10. Okay for gcc trunk?
>
> http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00045.html has the first hunk so
> you should credit Dmitry.
>
> --
> Eric Botcazou
Eric,
I didn't see that patch so just reduce mine down to the change for change
for gcc/varpool.c. Odd that the gcc/varpool.c issue isn't seen on other targets
besides darwin apparently.
Jack
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH} fix --enable-build-with-cxx
2011-05-05 12:56 ` Jack Howarth
@ 2011-05-05 12:58 ` Gabriel Dos Reis
2011-05-05 13:07 ` Jack Howarth
2011-05-05 13:38 ` Eric Botcazou
1 sibling, 1 reply; 7+ messages in thread
From: Gabriel Dos Reis @ 2011-05-05 12:58 UTC (permalink / raw)
To: Jack Howarth; +Cc: Eric Botcazou, gcc-patches
On Thu, May 5, 2011 at 7:55 AM, Jack Howarth <howarth@bromo.med.uc.edu> wrote:
> On Thu, May 05, 2011 at 02:02:19PM +0200, Eric Botcazou wrote:
>> > Currently the bootstrap with --enable-build-with-cxx is broken due to
>> > compiler errors of the form "error: converting 'false' to pointer type
>> > 'varpool_node*' [-Werror=conversion-null]". The attached patch changes
>> > these instances of false to NULL and restores the --enable-build-with-cxx
>> > bootstrap. Tested on x86_64-apple-darwin10. Okay for gcc trunk?
>>
>> http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00045.html has the first hunk so
>> you should credit Dmitry.
>>
>> --
>> Eric Botcazou
>
> Eric,
> I didn't see that patch so just reduce mine down to the change for change
> for gcc/varpool.c. Odd that the gcc/varpool.c issue isn't seen on other targets
> besides darwin apparently.
the patch is OK as obvious.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH} fix --enable-build-with-cxx
2011-05-05 12:58 ` Gabriel Dos Reis
@ 2011-05-05 13:07 ` Jack Howarth
2011-05-05 13:43 ` Gabriel Dos Reis
0 siblings, 1 reply; 7+ messages in thread
From: Jack Howarth @ 2011-05-05 13:07 UTC (permalink / raw)
To: Gabriel Dos Reis; +Cc: Eric Botcazou, gcc-patches
On Thu, May 05, 2011 at 07:56:20AM -0500, Gabriel Dos Reis wrote:
> On Thu, May 5, 2011 at 7:55 AM, Jack Howarth <howarth@bromo.med.uc.edu> wrote:
> > On Thu, May 05, 2011 at 02:02:19PM +0200, Eric Botcazou wrote:
> >> > Currently the bootstrap with --enable-build-with-cxx is broken due to
> >> > compiler errors of the form "error: converting 'false' to pointer type
> >> > 'varpool_node*' [-Werror=conversion-null]". The attached patch changes
> >> > these instances of false to NULL and restores the --enable-build-with-cxx
> >> > bootstrap. Tested on x86_64-apple-darwin10. Okay for gcc trunk?
> >>
> >> http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00045.html has the first hunk so
> >> you should credit Dmitry.
> >>
> >> --
> >> Eric Botcazou
> >
> > Eric,
> > I didn't see that patch so just reduce mine down to the change for change
> > for gcc/varpool.c. Odd that the gcc/varpool.c issue isn't seen on other targets
> > besides darwin apparently.
>
> the patch is OK as obvious.
Gabriel,
Thanks. I recall during gcc 4.6's development that there was some discussion of
defaulting on --enable-build-with-cxx for the stage2 compiler and later (such that
only the bootstrapped g++ compiler would be used by --enable-build-with-cxx). Is
that change likely to happen for gcc 4.7?
Jack
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH} fix --enable-build-with-cxx
2011-05-05 12:56 ` Jack Howarth
2011-05-05 12:58 ` Gabriel Dos Reis
@ 2011-05-05 13:38 ` Eric Botcazou
1 sibling, 0 replies; 7+ messages in thread
From: Eric Botcazou @ 2011-05-05 13:38 UTC (permalink / raw)
To: Jack Howarth; +Cc: gcc-patches
> I didn't see that patch so just reduce mine down to the change for
> change for gcc/varpool.c. Odd that the gcc/varpool.c issue isn't seen on
> other targets besides darwin apparently.
No problem. Please install the entire patch (with Dmitry's name as second
name) as Dmitry hasn't got commit rights.
--
Eric Botcazou
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH} fix --enable-build-with-cxx
2011-05-05 13:07 ` Jack Howarth
@ 2011-05-05 13:43 ` Gabriel Dos Reis
0 siblings, 0 replies; 7+ messages in thread
From: Gabriel Dos Reis @ 2011-05-05 13:43 UTC (permalink / raw)
To: Jack Howarth; +Cc: gcc-patches
On Thu, May 5, 2011 at 8:02 AM, Jack Howarth <howarth@bromo.med.uc.edu> wrote:
> On Thu, May 05, 2011 at 07:56:20AM -0500, Gabriel Dos Reis wrote:
>> On Thu, May 5, 2011 at 7:55 AM, Jack Howarth <howarth@bromo.med.uc.edu> wrote:
>> > On Thu, May 05, 2011 at 02:02:19PM +0200, Eric Botcazou wrote:
>> >> > Currently the bootstrap with --enable-build-with-cxx is broken due to
>> >> > compiler errors of the form "error: converting 'false' to pointer type
>> >> > 'varpool_node*' [-Werror=conversion-null]". The attached patch changes
>> >> > these instances of false to NULL and restores the --enable-build-with-cxx
>> >> > bootstrap. Tested on x86_64-apple-darwin10. Okay for gcc trunk?
>> >>
>> >> http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00045.html has the first hunk so
>> >> you should credit Dmitry.
>> >>
>> >> --
>> >> Eric Botcazou
>> >
>> > Eric,
>> > I didn't see that patch so just reduce mine down to the change for change
>> > for gcc/varpool.c. Odd that the gcc/varpool.c issue isn't seen on other targets
>> > besides darwin apparently.
>>
>> the patch is OK as obvious.
>
> Gabriel,
> Thanks. I recall during gcc 4.6's development that there was some discussion of
> defaulting on --enable-build-with-cxx for the stage2 compiler and later (such that
> only the bootstrapped g++ compiler would be used by --enable-build-with-cxx). Is
> that change likely to happen for gcc 4.7?
> Jack
I hope it does -- Ian may have more ideas about that.
-- Gaby
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-05-05 13:38 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-05 11:55 [PATCH} fix --enable-build-with-cxx Jack Howarth
2011-05-05 12:08 ` Eric Botcazou
2011-05-05 12:56 ` Jack Howarth
2011-05-05 12:58 ` Gabriel Dos Reis
2011-05-05 13:07 ` Jack Howarth
2011-05-05 13:43 ` Gabriel Dos Reis
2011-05-05 13:38 ` Eric Botcazou
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).