From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26891 invoked by alias); 10 May 2011 18:55:58 -0000 Received: (qmail 26881 invoked by uid 22791); 10 May 2011 18:55:57 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (38.113.113.100) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 May 2011 18:55:43 +0000 Received: (qmail 32341 invoked from network); 10 May 2011 18:55:42 -0000 Received: from unknown (HELO localhost) (froydnj@127.0.0.2) by mail.codesourcery.com with ESMTPA; 10 May 2011 18:55:42 -0000 Date: Tue, 10 May 2011 20:08:00 -0000 From: Nathan Froyd To: Richard Guenther Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 12/18] make CASE_LABEL_EXPR not abuse TREE_CHAIN Message-ID: <20110510185541.GA7390@codesourcery.com> References: <1299817406-16745-1-git-send-email-froydnj@codesourcery.com> <1299817406-16745-13-git-send-email-froydnj@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.17+20080114 (2008-01-14) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg00787.txt.bz2 On Fri, Mar 11, 2011 at 02:19:14PM +0100, Richard Guenther wrote: > On Fri, Mar 11, 2011 at 5:23 AM, Nathan Froyd wrote: > > Move CASE_CHAIN into a local operand for CASE_LABEL_EXPR.  Nothing to > > see here. > > I wonder if there isn't a better way to do this ... like always requiring > operand 2 of SWITCH_EXPRs. I'm honestly not sure. Would it be OK to commit the patch and discuss other options later? CASE_LABEL is the last expression-esque node using TREE_CHAIN. -Nathan