From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3285 invoked by alias); 15 May 2011 22:09:43 -0000 Received: (qmail 3275 invoked by uid 22791); 15 May 2011 22:09:43 -0000 X-SWARE-Spam-Status: No, hits=-0.5 required=5.0 tests=AWL,BAYES_50,TW_CX X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 15 May 2011 22:09:28 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id B450CCB0248; Mon, 16 May 2011 00:09:27 +0200 (CEST) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id DT6wBN4sebsL; Mon, 16 May 2011 00:09:24 +0200 (CEST) Received: from [192.168.1.2] (bon31-9-83-155-120-49.fbx.proxad.net [83.155.120.49]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id 9B63CCB0220; Mon, 16 May 2011 00:09:24 +0200 (CEST) From: Eric Botcazou To: Kai Tietz Subject: Re: [patch gimplifier]: Make sure TRUTH_NOT_EXPR has boolean_type_node type and argument Date: Mon, 16 May 2011 02:16:00 -0000 User-Agent: KMail/1.9.9 Cc: gcc-patches@gcc.gnu.org, Andrew Pinski , Richard Guenther References: <201105151741.42795.ebotcazou@adacore.com> In-Reply-To: MIME-Version: 1.0 Content-Disposition: inline Message-Id: <201105160008.56351.ebotcazou@adacore.com> Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg01085.txt.bz2 > With this patch (which would describe why it gimplifier sees > integer-type nodes here): > > Index: gcc/gcc/ada/gcc-interface/trans.c > =================================================================== > --- gcc.orig/gcc/ada/gcc-interface/trans.c 2011-05-12 > 20:06:01.000000000 +0200 > +++ gcc/gcc/ada/gcc-interface/trans.c 2011-05-15 15:33:32.305516200 +0200 > @@ -7101,7 +7110,7 @@ convert_with_check (Entity_Id gnat_type, > { > /* Ensure GNU_EXPR only gets evaluated once. */ > tree gnu_input = gnat_protect_expr (gnu_result); > - tree gnu_cond = integer_zero_node; > + tree gnu_cond = boolean_false_node; > tree gnu_in_lb = TYPE_MIN_VALUE (gnu_in_basetype); > tree gnu_in_ub = TYPE_MAX_VALUE (gnu_in_basetype); > tree gnu_out_lb = TYPE_MIN_VALUE (gnu_base_type); > > I was able to do a bootstrap for ada and run 'make check-ada' without > seeing gimplification errors. The patch is OK, but it doesn't change anything for c52103x as this is a pure gimplifier problem. Try running ACATS at -O0: Index: ada/acats/run_all.sh =================================================================== --- ada/acats/run_all.sh (revision 173756) +++ ada/acats/run_all.sh (working copy) @@ -9,7 +9,7 @@ # gccflags="-O3 -fomit-frame-pointer -funroll-all-loops -finline-functions" # gnatflags="-gnatN" -gccflags="-O2" +gccflags="" gnatflags="-gnatws" target_run () { and you'll see the failures. > The only failure I see in testrun is 'cxg2001.adb' test with 'GCC > error: in compensate_edge, at reg-stach.c:2781' Error detect around > cxg2001.adb:322:5. But well, this bug seems to me unrelated here to > gimplication. Yes, the cxg2001 failure is PR rtl-optimization/48633. -- Eric Botcazou