public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jan Hubicka <hubicka@ucw.cz>
To: Xinliang David Li <davidxl@google.com>
Cc: Andi Kleen <andi@firstfloor.org>, Jan Hubicka <hubicka@ucw.cz>,
	Paolo Bonzini <bonzini@gnu.org>, Rong Xu <xur@google.com>,
	reply@codereview.appspotmail.com, gcc-patches@gcc.gnu.org
Subject: Re: [google] support for building Linux kernel with FDO	(issue4523061)
Date: Tue, 17 May 2011 06:36:00 -0000	[thread overview]
Message-ID: <20110516231304.GA29179@kam.mff.cuni.cz> (raw)
In-Reply-To: <BANLkTim1-JNbQkEKiBdyHef9=-cw7P-B1w@mail.gmail.com>

> On Mon, May 16, 2011 at 3:38 PM, Andi Kleen <andi@firstfloor.org> wrote:
> > Jan Hubicka <hubicka@ucw.cz> writes:
> >> Yep,
> >> I think it does make sense to share the implementation, but we need to find
> >> resonable way to do so.
> >
> > I doubt this will be very popular with the kernel community, which
> > prefers self contained code.
> 
> Won't be surprised if there are objections ..
> 
> >
> > Also the interface doesn't change that often or does it?
> 
> As FDO gains popularity,  the profile coverage code will change faster
> than people may think.  To quote some potential ones -- lightweight
> ipo, path profiling, call trace profiling etc.
> 
> >
> > The current kernel code is for gcc 3. That could be simply
> > replaced with a modern gcc 4 interface.
> 
> Rong's approach will let kernel get coverage + FDO support almost for
> free -- there is no need for kernel to maintain something is basically
> not maintainable.

One other plus for "embeddable gcov" is that Linux kernel is not the only
potential consumer of this infrastructure.  So from sole gcov maintainer POV, I
think adding such support for interface an dmaking libgcov building in its own
directory is a positive thing.  I doubt I will however have time to implement
it myself this stage1 - the list of high priority things is just too long.
Patches would be welcome, however.  If kernel developers decides to maintain
its own variant of libgcov, it is not big problem with me either and I am
trying to keep the interface stable unless there are good reasons to break it.

It is however clear that we will break libgcov interface this GCC release (we
already did) and given new interest in it, probably in releases to come, too.

Honza

  reply	other threads:[~2011-05-16 23:13 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-13  9:10 Rong Xu
2011-05-13  9:23 ` Xinliang David Li
2011-05-13 10:12   ` Richard Guenther
2011-05-13 12:43     ` Jan Hubicka
2011-05-13 17:14       ` Andi Kleen
2011-05-13 13:58 ` Paolo Bonzini
2011-05-13 18:44   ` Xinliang David Li
2011-05-13 18:59     ` Paolo Bonzini
2011-05-13 22:24     ` Rong Xu
2011-05-13 22:31     ` Rong Xu
2011-05-13 22:33       ` Rong Xu
2011-05-15 19:34     ` Jan Hubicka
2011-05-17  2:41       ` Xinliang David Li
2011-05-17  5:28       ` Andi Kleen
2011-05-17  5:30         ` Rong Xu
2011-05-17  7:03           ` Andi Kleen
2011-05-17  7:11             ` Rong Xu
2011-10-14  3:44               ` vulcansh
2011-10-14  6:51                 ` Xinliang David Li
2011-10-14 22:59                   ` vulcansh
     [not found]                     ` <CAAkRFZ+54idDZZz2xDb4K+132pSva-1LB-3Zeb__ma_O20Kt4w@mail.gmail.com>
2011-10-15  4:50                       ` Rong Xu
2011-05-17  6:35         ` Xinliang David Li
2011-05-17  6:36           ` Jan Hubicka [this message]
2011-05-17  7:10       ` Rong Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110516231304.GA29179@kam.mff.cuni.cz \
    --to=hubicka@ucw.cz \
    --cc=andi@firstfloor.org \
    --cc=bonzini@gnu.org \
    --cc=davidxl@google.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=reply@codereview.appspotmail.com \
    --cc=xur@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).