From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23723 invoked by alias); 21 May 2011 03:01:56 -0000 Received: (qmail 23711 invoked by uid 22791); 21 May 2011 03:01:55 -0000 X-SWARE-Spam-Status: No, hits=-6.3 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 21 May 2011 03:01:38 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4L31Z3l022098 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 20 May 2011 23:01:35 -0400 Received: from greed.delorie.com (ovpn-113-169.phx2.redhat.com [10.3.113.169]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p4L31YIL024024 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 20 May 2011 23:01:35 -0400 Received: from greed.delorie.com (localhost.localdomain [127.0.0.1]) by greed.delorie.com (8.14.4/8.14.4) with ESMTP id p4L31Wh8017983; Fri, 20 May 2011 23:01:32 -0400 Received: (from dj@localhost) by greed.delorie.com (8.14.4/8.14.4/Submit) id p4L31WDU017982; Fri, 20 May 2011 23:01:32 -0400 Date: Sat, 21 May 2011 11:46:00 -0000 Message-Id: <201105210301.p4L31WDU017982@greed.delorie.com> From: DJ Delorie To: Rainer Orth CC: gcc-patches@gcc.gnu.org, bonzini@gnu.org, Ralf.Wildenhues@gmx.de In-reply-to: (message from Rainer Orth on Thu, 19 May 2011 10:16:18 +0200) Subject: Re: Unreviewed build patches References: X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg01517.txt.bz2 > [build] More --enable-threads cleanup > http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00059.html > > This might well be obvious. Also, we usually leave those up to the target maintainers, since they're target specific. But if it's just a correlation between the script and a list of source file options, go for it. > Besides, it would be helpful if a build maintainer could have a look at > > [build] Move Solaris 2 startup files to toplevel libgcc > http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00098.html > > either to state that I don't need approval or to make suggestings for > improvements. This is not yet the final patch, but the remainder is > tuning. We normally let target maintainers manage anything in the build that's target-specific. However, you've mixed in target patches with target-independent patches. I have no problem with you checking in your own target changes, but if you could split out the rest for review, it would make it easier on us. Also, mention if you tested it on any ix86 non-solaris platform (linux, bsd, etc).