From: Basile Starynkevitch <basile@starynkevitch.net>
To: Piervit <piervit@pvittet.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: external declaration of dominance debug functions
Date: Mon, 23 May 2011 09:56:00 -0000 [thread overview]
Message-ID: <20110523085901.GA16533@ours.starynkevitch.net> (raw)
In-Reply-To: <20110523103355.71528d09@zenwalk.local>
On Mon, May 23, 2011 at 10:33:55AM +0200, Piervit wrote:
>
> Here is a two lines patch, allowing to use debug_dominance_info and
> debug_dominance_tree functions outside of gcc/dominance.c.
> +extern void debug_dominance_info (enum cdi_direction dir);
> +extern void debug_dominance_tree (enum cdi_direction dir, basic_block root);
> +
> #include "cfghooks.h"
Please put all declarations after the #include, and add a simple comment describing
what the functions are doing.
With this improvement, I really hope the patch will be accepted,
because plugins really need to be able to call all the debug printing routines.
As I told many times, debug printing routines are more useful
for novice plugin developers that to experts working since many years on GCC.
Regards
--
Basile STARYNKEVITCH http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mines, sont seulement les miennes} ***
next prev parent reply other threads:[~2011-05-23 8:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 9:49 Piervit
2011-05-23 9:56 ` Basile Starynkevitch [this message]
2011-05-23 10:22 ` Richard Guenther
2011-05-23 10:53 ` Piervit
2011-05-23 20:55 ` Basile Starynkevitch
2011-05-23 22:52 ` Richard Guenther
2011-05-23 23:06 ` Nathan Froyd
2011-05-23 23:06 ` Richard Guenther
2011-05-24 10:42 ` Basile Starynkevitch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110523085901.GA16533@ours.starynkevitch.net \
--to=basile@starynkevitch.net \
--cc=gcc-patches@gcc.gnu.org \
--cc=piervit@pvittet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).