From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21371 invoked by alias); 23 May 2011 08:59:45 -0000 Received: (qmail 21347 invoked by uid 22791); 23 May 2011 08:59:44 -0000 X-SWARE-Spam-Status: No, hits=-0.3 required=5.0 tests=AWL,BAYES_50,RCVD_IN_DNSWL_NONE X-Spam-Check-By: sourceware.org Received: from smtp-151-monday.nerim.net (HELO maiev.nerim.net) (194.79.134.151) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 May 2011 08:59:29 +0000 Received: from hector.lesours (ours.starynkevitch.net [213.41.244.95]) by maiev.nerim.net (Postfix) with ESMTPS id E2C9B2E031; Mon, 23 May 2011 10:59:27 +0200 (CEST) Received: from basile18 by hector.lesours with local (Exim 4.76) (envelope-from ) id 1QOQyi-0004J8-4Q; Mon, 23 May 2011 10:59:08 +0200 Date: Mon, 23 May 2011 09:56:00 -0000 From: Basile Starynkevitch To: Piervit Cc: gcc-patches@gcc.gnu.org Subject: Re: external declaration of dominance debug functions Message-ID: <20110523085901.GA16533@ours.starynkevitch.net> References: <20110523103355.71528d09@zenwalk.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20110523103355.71528d09@zenwalk.local> User-Agent: Mutt/1.5.21 (2010-09-15) X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg01598.txt.bz2 On Mon, May 23, 2011 at 10:33:55AM +0200, Piervit wrote: > > Here is a two lines patch, allowing to use debug_dominance_info and > debug_dominance_tree functions outside of gcc/dominance.c. > +extern void debug_dominance_info (enum cdi_direction dir); > +extern void debug_dominance_tree (enum cdi_direction dir, basic_block root); > + > #include "cfghooks.h" Please put all declarations after the #include, and add a simple comment describing what the functions are doing. With this improvement, I really hope the patch will be accepted, because plugins really need to be able to call all the debug printing routines. As I told many times, debug printing routines are more useful for novice plugin developers that to experts working since many years on GCC. Regards -- Basile STARYNKEVITCH http://starynkevitch.net/Basile/ email: basilestarynkevitchnet mobile: +33 6 8501 2359 8, rue de la Faiencerie, 92340 Bourg La Reine, France *** opinions {are only mines, sont seulement les miennes} ***