From: Piervit <piervit@pvittet.com>
To: gcc-patches@gcc.gnu.org, richard.guenther@gmail.com
Subject: Re: external declaration of dominance debug functions
Date: Mon, 23 May 2011 10:53:00 -0000 [thread overview]
Message-ID: <20110523115632.5abb6956@zenwalk.local> (raw)
In-Reply-To: <BANLkTimZPCQo+bD01UVXEERT-mS+as1rgw@mail.gmail.com>
Le Mon, 23 May 2011 11:30:34 +0200,
Richard Guenther <richard.guenther@gmail.com> a écrit :
> On Mon, May 23, 2011 at 10:33 AM, Piervit <piervit@pvittet.com> wrote:
> > Hello,
> >
> > Here is a two lines patch, allowing to use debug_dominance_info and
> > debug_dominance_tree functions outside of gcc/dominance.c. For the
> > moment, those functions are not declared in any gcc/*.h files (as
> > far as I know after trying a grep). I have added them as external
> > functions into gcc/basic-block.h. I feel this is useful to be able
> > to call those functions from others files, for exemple from plugins.
>
> debug_* functions are supposed to be used from interactive gdb
> sessions. They should not be advertised in public headers.
>
> Richard.
>
> > ChangeLog:
> >
> > 2011-05-23 Pierre Vittet <piervit@pvittet.com>
> >
> > * basic-block.h (debug_dominance_info, debug_dominance_tree):
> > Add declaration.
Thank you for your answer. I am sorry I was not aware of this rule.
However I have try the following command in the gcc/ directory:
pierre@zenwalk gcc %grep " debug_*" *.h | wc -l
231
And the majority of the result are debug_* functions in header file,
such as extern void debug_tree (tree); in tree.h, extern void
debug_pass (void); in tree-pass.h and many others.
next prev parent reply other threads:[~2011-05-23 9:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 9:49 Piervit
2011-05-23 9:56 ` Basile Starynkevitch
2011-05-23 10:22 ` Richard Guenther
2011-05-23 10:53 ` Piervit [this message]
2011-05-23 20:55 ` Basile Starynkevitch
2011-05-23 22:52 ` Richard Guenther
2011-05-23 23:06 ` Nathan Froyd
2011-05-23 23:06 ` Richard Guenther
2011-05-24 10:42 ` Basile Starynkevitch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110523115632.5abb6956@zenwalk.local \
--to=piervit@pvittet.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).