From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9475 invoked by alias); 30 May 2011 08:21:30 -0000 Received: (qmail 9457 invoked by uid 22791); 30 May 2011 08:21:29 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from nikam.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 May 2011 08:21:14 +0000 Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id 98D049AC812; Mon, 30 May 2011 10:21:12 +0200 (CEST) Date: Mon, 30 May 2011 10:13:00 -0000 From: Jan Hubicka To: Paolo Bonzini Cc: Richard Guenther , Jan Hubicka , gcc-patches@gcc.gnu.org, rguenther@suse.de Subject: Re: Faster string streaming Message-ID: <20110530082112.GD10020@kam.mff.cuni.cz> References: <20110529143135.GC3577@kam.mff.cuni.cz> <4DE33FF0.4020707@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4DE33FF0.4020707@gnu.org> User-Agent: Mutt/1.5.18 (2008-05-17) Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg02308.txt.bz2 > On 05/29/2011 06:14 PM, Richard Guenther wrote: >>> > >>> > -/* Returns a hash code for P. */ >>> > +/* Returns a hash code for P. >>> > + Shamelessly*/ >> ... stolen from libiberty. >> >> ? >> >> Ok with that comment adjusted. > > Why steal it :) if you can instead add the code to libiberty? Well, it is 3 lines of code so it seemed easier to steal it ;) You won't be able to use it directly anyway since you need wrapping structure around the string since libiberty hashtable won't let you store strings and sizes directly into it. Honza